Adding parsing for partition and persistence attributes to the <browser> tag

content/renderer/browser_plugin/browser_plugin.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
 #define  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
 
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/sequenced_task_runner_helpers.h"
 #include "content/renderer/browser_plugin/browser_plugin_backing_store.h"
 #include "content/renderer/browser_plugin/browser_plugin_bindings.h"
 #include "content/renderer/render_view_impl.h"
 
 struct BrowserPluginMsg_UpdateRect_Params;
 
 namespace content {
 
 class BrowserPluginManager;
 class MockBrowserPlugin;
 
 class CONTENT_EXPORT BrowserPlugin :
     NON_EXPORTED_BASE(public WebKit::WebPlugin) {
  public:
+  enum BoolAttribute {

[michaeln, 2012/09/10 23:01:43]

Doesn't look like this needs to be public. Actually is the fancy tri-state type
really needed? So long as the value isn't mutated after the plugin has
navigated, what's the harm in changing it.

[nasko, 2012/09/10 23:16:08]

We want to raise an exception if JavaScript is used to modify the value, in
order to make it visible to developers that this is unsupported. Hence, I wanted
to know the case of "unset".

+    UNSET_VALUE = -1,
+    FALSE_VALUE,
+    TRUE_VALUE
+  };
+
   // Called only by tests to clean up before we blow away the MockRenderProcess.
   void Cleanup();
 
   // Get the src attribute value of the BrowserPlugin instance if the guest
   // has not crashed.
   std::string GetSrcAttribute() const;
   // Set the src attribute value of the BrowserPlugin instance and reset
   // the guest_crashed_ flag.
   void SetSrcAttribute(const std::string& src);
 
+  std::string GetPartitionAttribute() const;
+  bool SetPartitionAttribute(const std::string& partition_id);
+
+  bool GetPersistAttribute() const;
+  bool SetPersistAttribute(bool persist);
+
   // Inform the BrowserPlugin to update its backing store with the pixels in
   // its damage buffer.
   void UpdateRect(int message_id,
                   const BrowserPluginMsg_UpdateRect_Params& params);
   // Inform the BrowserPlugin that its guest has crashed.
   void GuestCrashed();
   // Informs the BrowserPlugin that the guest has navigated to a new URL.
   void DidNavigate(const GURL& url);
   // Tells the BrowserPlugin to advance the focus to the next (or previous)
   // element.
@@ skipping 63 matching lines @@
       const WebKit::WebPluginParams& params);
 
   virtual ~BrowserPlugin();
 
   int width() const { return plugin_rect_.width(); }
   int height() const { return plugin_rect_.height(); }
 
   // Virtual to allow for mocking in tests.
   virtual float GetDeviceScaleFactor() const;
 
-  // Parses the source URL of the browser plugin from the element's attributes
-  // and outputs them.
-  bool ParseSrcAttribute(const WebKit::WebPluginParams& params,
-                         std::string* src);
+  // Parses the attributes of the browser plugin from the element's attributes
+  // and sets them appropriately.
+  void ParseAttributes(const WebKit::WebPluginParams& params);
 
   // Cleanup event listener state to free v8 resources when a BrowserPlugin
   // is destroyed.
   void RemoveEventListeners();
 
   int instance_id_;
   RenderViewImpl* render_view_;
   WebKit::WebPluginContainer* container_;
   scoped_ptr<BrowserPluginBindings> bindings_;
   scoped_ptr<BrowserPluginBackingStore> backing_store_;
   TransportDIB* damage_buffer_;
   gfx::Rect plugin_rect_;
   // Bitmap for crashed plugin. Lazily initialized, non-owning pointer.
   SkBitmap* sad_guest_;
   bool guest_crashed_;
   bool resize_pending_;
   long long parent_frame_;
+  bool has_navigated_;
   std::string src_;
+  std::string partition_id_;
+  BoolAttribute persist_storage_;
   typedef std::vector<v8::Persistent<v8::Function> > EventListeners;
   typedef std::map<std::string, EventListeners> EventListenerMap;
   EventListenerMap event_listener_map_;
   DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_