chrome/common/extensions/extension_manifest_constants.cc - Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_manifest_constants.cc

Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix fix Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_manifest_constants.cc

diff --git a/chrome/common/extensions/extension_manifest_constants.cc b/chrome/common/extensions/extension_manifest_constants.cc

index ad5e4463af89a82b7a6fb50802c4e549f287ef97..064466ff9269dc62903c787b31612979d950a926 100644

--- a/chrome/common/extensions/extension_manifest_constants.cc

+++ b/chrome/common/extensions/extension_manifest_constants.cc

@@ -329,7 +329,10 @@ const char kInvalidLaunchValueContainer[] =

const char kInvalidManifest[] =

"Manifest file is invalid.";

const char kInvalidManifestVersion[] =

- "The 'manifest_version' key must be present and set to 2 (without quotes).";

+ "Invalid value for 'manifest_version'. Must be an integer greater than zero.";

+const char kInvalidManifestVersionOld[] =

+ "The 'manifest_version' key must be present and set to 2 (without quotes). "

+ "See developer.chrome.com/extensions/manifestVersion.html for details.";

const char kInvalidMatch[] =

"Invalid value for 'content_scripts[*].matches[*]': *";

const char kInvalidMatchCount[] =