Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/ui/webui/extensions/pack_extension_handler.cc

Issue 10912041: Disallow packing or loading unpacked manifest v1 extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix fix Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/pack_extension_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
index 427daddc228fbb4800c756801fd7c186e5e3adf0..1f5f37c9da93089f0bee8db63b5e50d5794d46dc 100644
--- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
+++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc
@@ -4,10 +4,10 @@
#include "chrome/browser/ui/webui/extensions/pack_extension_handler.h"
-#include "chrome/browser/extensions/extension_creator.h"
-#include "chrome/browser/ui/chrome_select_file_policy.h"
#include "base/bind.h"
#include "base/utf_string_conversions.h"
+#include "chrome/browser/extensions/extension_creator.h"
+#include "chrome/browser/ui/chrome_select_file_policy.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_view.h"
#include "content/public/browser/web_ui.h"
@@ -117,7 +117,9 @@ void PackExtensionHandler::HandlePackMessage(const ListValue* args) {
if (!args->GetDouble(2, &flags_double))
NOTREACHED();
- int run_flags = static_cast<int>(flags_double);
+ int run_flags =
+ static_cast<int>(flags_double) |
+ extensions::ExtensionCreator::kRequireModernManifestVersion;
FilePath root_directory =
FilePath::FromWStringHack(UTF8ToWide(extension_path_));

Powered by Google App Engine
This is Rietveld 408576698