Disallow packing or loading unpacked manifest v1 extensions.

chrome/browser/extensions/extension_apitest.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_
 
 #include <deque>
 #include <string>
 
@@ skipping 14 matching lines @@
 
 
 // The general flow of these API tests should work like this:
 // (1) Setup initial browser state (e.g. create some bookmarks for the
 //     bookmark test)
 // (2) Call ASSERT_TRUE(RunExtensionTest(name));
 // (3) In your extension code, run your test and call chrome.test.pass or
 //     chrome.test.fail
 // (4) Verify expected browser state.
 // TODO(erikkay): There should also be a way to drive events in these tests.
-
 class ExtensionApiTest : public ExtensionBrowserTest {
  public:
   // Flags used to configure how the tests are run.
+  // TODO(aa): Many of these are dupes of ExtensionBrowserTest::Flags. Combine
+  // somehow?
   enum Flags {
     kFlagNone = 0,
 
     // Allow the extension to run in incognito mode.
     kFlagEnableIncognito = 1 << 0,
 
     // Launch the test page in an incognito window.
     kFlagUseIncognito = 1 << 1,
 
     // Allow file access for the extension.
     kFlagEnableFileAccess = 1 << 2,
 
     // Loads the extension with location COMPONENT.
     kFlagLoadAsComponent = 1 << 3,
 
     // Launch the extension as a platform app.
     kFlagLaunchPlatformApp = 1 << 4,
 
-    // Don't fail when the loaded manifest has warnings (should only be used
-    // when testing deprecated features).
-    kFlagIgnoreManifestWarnings = 1 << 5
+    // Don't fail when the loaded manifest has warnings.
+    kFlagIgnoreManifestWarnings = 1 << 5,
+
+    // Allow manifest versions older that Extension::kModernManifestVersion.
+    // Used to test old manifest features.
+    kFlagAllowOldManifestVersions = 1 << 6,
   };
 
   ExtensionApiTest();
   virtual ~ExtensionApiTest();
 
  protected:
   // Helper class that observes tests failing or passing. Observation starts
   // when the class is constructed. Get the next result by calling
   // GetNextResult() and message() if GetNextResult() return false. If there
   // are no results, this method will pump the UI message loop until one is
@@ skipping 39 matching lines @@
   // Load |extension_name| and wait for pass / fail notification.
   // |extension_name| is a directory in "test/data/extensions/api_test".
   bool RunExtensionTest(const char* extension_name);
 
   // Same as RunExtensionTest, but enables the extension for incognito mode.
   bool RunExtensionTestIncognito(const char* extension_name);
 
   // Same as RunExtensionTest, but ignores any warnings in the manifest.
   bool RunExtensionTestIgnoreManifestWarnings(const char* extension_name);
 
+  // Same as RunExtensionTest, allow old manifest ersions.
+  bool RunExtensionTestAllowOldManifestVersion(const char* extension_name);
+
   // Same as RunExtensionTest, but loads extension as component.
   bool RunComponentExtensionTest(const char* extension_name);
 
   // Same as RunExtensionTest, but disables file access.
   bool RunExtensionTestNoFileAccess(const char* extension_name);
 
   // Same as RunExtensionTestIncognito, but disables file access.
   bool RunExtensionTestIncognitoNoFileAccess(const char* extension_name);
 
   // If not empty, Load |extension_name|, load |page_url| and wait for pass /
@@ skipping 55 matching lines @@
 // apps (if any).
 class PlatformAppApiTest : public ExtensionApiTest {
  public:
   PlatformAppApiTest();
   virtual ~PlatformAppApiTest();
 
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_APITEST_H_