Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: runtime/vm/assembler_x64.cc

Issue 10912028: Fix computations in LeaveCallRuntimeFrame to use kDoubleSize for saved XMM registers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/heap.h" 9 #include "vm/heap.h"
10 #include "vm/memory_region.h" 10 #include "vm/memory_region.h"
(...skipping 1681 matching lines...) Expand 10 before | Expand all | Expand 10 after
1692 static const Register volatile_cpu_registers[kNumberOfVolatileCpuRegisters] = { 1692 static const Register volatile_cpu_registers[kNumberOfVolatileCpuRegisters] = {
1693 RAX, RCX, RDX, RSI, RDI, R8, R9, R10, R11 1693 RAX, RCX, RDX, RSI, RDI, R8, R9, R10, R11
1694 }; 1694 };
1695 1695
1696 // XMM0 is used only as a scratch register in the optimized code. No need to 1696 // XMM0 is used only as a scratch register in the optimized code. No need to
1697 // save it. 1697 // save it.
1698 static const intptr_t kNumberOfVolatileXmmRegisters = 1698 static const intptr_t kNumberOfVolatileXmmRegisters =
1699 kNumberOfXmmRegisters - 1; 1699 kNumberOfXmmRegisters - 1;
1700 1700
1701 1701
1702 static const intptr_t kNumberOfVolatileRegisters =
1703 kNumberOfVolatileCpuRegisters + kNumberOfVolatileXmmRegisters;
1704
1705
1706 void Assembler::EnterCallRuntimeFrame(intptr_t frame_space) { 1702 void Assembler::EnterCallRuntimeFrame(intptr_t frame_space) {
1707 enter(Immediate(0)); 1703 enter(Immediate(0));
1708 1704
1709 // Preserve volatile CPU registers. 1705 // Preserve volatile CPU registers.
1710 for (intptr_t i = 0; i < kNumberOfVolatileCpuRegisters; i++) { 1706 for (intptr_t i = 0; i < kNumberOfVolatileCpuRegisters; i++) {
1711 pushq(volatile_cpu_registers[i]); 1707 pushq(volatile_cpu_registers[i]);
1712 } 1708 }
1713 1709
1714 // Preserve all XMM registers except XMM0 1710 // Preserve all XMM registers except XMM0
1715 subq(RSP, Immediate((kNumberOfXmmRegisters - 1) * kDoubleSize)); 1711 subq(RSP, Immediate((kNumberOfXmmRegisters - 1) * kDoubleSize));
1716 // Store XMM registers with the lowest register number at the lowest 1712 // Store XMM registers with the lowest register number at the lowest
1717 // address. 1713 // address.
1718 intptr_t offset = 0; 1714 intptr_t offset = 0;
1719 for (intptr_t reg_idx = 1; reg_idx < kNumberOfXmmRegisters; ++reg_idx) { 1715 for (intptr_t reg_idx = 1; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
1720 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx); 1716 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
1721 movsd(Address(RSP, offset), xmm_reg); 1717 movsd(Address(RSP, offset), xmm_reg);
1722 offset += kDoubleSize; 1718 offset += kDoubleSize;
1723 } 1719 }
1724 1720
1725 ReserveAlignedFrameSpace(frame_space); 1721 ReserveAlignedFrameSpace(frame_space);
1726 } 1722 }
1727 1723
1728 1724
1729 void Assembler::LeaveCallRuntimeFrame() { 1725 void Assembler::LeaveCallRuntimeFrame() {
1730 // RSP might have been modified to reserve space for arguments 1726 // RSP might have been modified to reserve space for arguments
1731 // and ensure proper alignment of the stack frame. 1727 // and ensure proper alignment of the stack frame.
1732 // We need to restore it before restoring registers. 1728 // We need to restore it before restoring registers.
1733 leaq(RSP, Address(RBP, -kNumberOfVolatileRegisters * kWordSize)); 1729 const intptr_t kPushedRegistersSize =
1730 kNumberOfVolatileCpuRegisters * kWordSize +
1731 kNumberOfVolatileXmmRegisters * kDoubleSize;
1732 leaq(RSP, Address(RBP, -kPushedRegistersSize));
1734 1733
1735 // Restore all XMM registers except XMM0 1734 // Restore all XMM registers except XMM0
1736 // XMM registers have the lowest register number at the lowest address. 1735 // XMM registers have the lowest register number at the lowest address.
1737 intptr_t offset = 0; 1736 intptr_t offset = 0;
1738 for (intptr_t reg_idx = 1; reg_idx < kNumberOfXmmRegisters; ++reg_idx) { 1737 for (intptr_t reg_idx = 1; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
1739 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx); 1738 XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
1740 movsd(xmm_reg, Address(RSP, offset)); 1739 movsd(xmm_reg, Address(RSP, offset));
1741 offset += kDoubleSize; 1740 offset += kDoubleSize;
1742 } 1741 }
1743 addq(RSP, Immediate(offset)); 1742 addq(RSP, Immediate(offset));
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
1969 1968
1970 const char* Assembler::XmmRegisterName(XmmRegister reg) { 1969 const char* Assembler::XmmRegisterName(XmmRegister reg) {
1971 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters)); 1970 ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
1972 return xmm_reg_names[reg]; 1971 return xmm_reg_names[reg];
1973 } 1972 }
1974 1973
1975 1974
1976 } // namespace dart 1975 } // namespace dart
1977 1976
1978 #endif // defined TARGET_ARCH_X64 1977 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698