Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6922)

Unified Diff: chrome/browser/policy/async_policy_provider.cc

Issue 10912017: Fix stack corruption bug in FilePathWatcherTest.Callback. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebased, added comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_path_watcher_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/async_policy_provider.cc
diff --git a/chrome/browser/policy/async_policy_provider.cc b/chrome/browser/policy/async_policy_provider.cc
index eb66d9b8114c09139d9cb690b54444125be87dce..71d45026a6cf63f1628782a22fdccb26d3357f10 100644
--- a/chrome/browser/policy/async_policy_provider.cc
+++ b/chrome/browser/policy/async_policy_provider.cc
@@ -16,14 +16,6 @@ using content::BrowserThread;
namespace policy {
-namespace {
-
-// Helper for a PostTaskAndReply used as a synchronization point between the
-// main thread and FILE thread. See AsyncPolicyProvider::RefreshPolicies.
-void Nop() {}
-
-} // namespace
-
AsyncPolicyProvider::AsyncPolicyProvider(scoped_ptr<AsyncPolicyLoader> loader)
: loader_(loader.release()),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
@@ -67,7 +59,7 @@ void AsyncPolicyProvider::RefreshPolicies() {
base::Unretained(this)));
BrowserThread::PostTaskAndReply(
BrowserThread::FILE, FROM_HERE,
- base::Bind(Nop),
+ base::Bind(base::DoNothing),
refresh_callback_.callback());
}
« no previous file with comments | « base/files/file_path_watcher_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698