Issue 10912017: Fix stack corruption bug in FilePathWatcherTest.Callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10912017: Fix stack corruption bug in FilePathWatcherTest.Callback. (Closed)

Created:
8 years, 3 months ago by Joao da Silva

Modified:
8 years, 3 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix stack corruption bug in FilePathWatcherTest.Callback. BUG=145653 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154406

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Rebased, added comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	base/files/file_path_watcher_browsertest.cc	View	1 2	4 chunks	+17 lines, -2 lines	0 comments	Download
	M	chrome/browser/policy/async_policy_provider.cc	View	1	2 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

8 years, 3 months ago (2012-08-30 19:09:31 UTC) #2

I'm fine with this, so LGTM with a nit. Another option would be to just disable
the test for now until we have a proper fix.

https://chromiumcodereview.appspot.com/10912017/diff/7001/base/files/file_pat...
File base/files/file_path_watcher_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10912017/diff/7001/base/files/file_pat...
base/files/file_path_watcher_browsertest.cc:292: // A better fix requires
significant changes to the FilePathWatcher.
TODO + bug.

Expand Messages | Collapse Messages