Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10912011: Change NaCl IPC PPAPI proxy startup to support a NaCl-Browser process (Closed)

Created:
8 years, 3 months ago by bbudge
Modified:
8 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Change NaCl IPC PPAPI proxy startup to support a NaCl-Browser process channel. NaClProcessHost now creates an initial NaCl-Browser channel, then uses it to send a message to create the NaCl-Renderer channel. The main() for the IPC-IRT creates a PpapiDispatcher object to manage this channel and manage the PluginDispatchers for each renderer. BUG=116317 TEST=manual TBR=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154231

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -106 lines) Patch
M build/common_untrusted.gypi View 1 1 chunk +15 lines, -20 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 4 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 6 chunks +56 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter.cc View 5 chunks +38 lines, -5 lines 0 comments Download
M chrome/nacl/nacl_listener.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M ppapi/proxy/plugin_main_nacl.cc View 4 chunks +139 lines, -49 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +8 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ppapi/proxy/serialized_structs.h View 5 chunks +17 lines, -8 lines 0 comments Download
M ppapi/proxy/serialized_structs.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bbudge
I had to revert this because of ARM build failures. I'm adding back the flag ...
8 years, 3 months ago (2012-08-30 17:16:25 UTC) #1
dmichael (off chromium)
8 years, 3 months ago (2012-08-30 17:50:41 UTC) #2
http://codereview.chromium.org/10912011/diff/1/build/common_untrusted.gypi
File build/common_untrusted.gypi (right):

http://codereview.chromium.org/10912011/diff/1/build/common_untrusted.gypi#ne...
build/common_untrusted.gypi:26: # TODO(bbudge) Figure out why above 'clang = 1'
doesn't fix this.
I'm not a gyp-spert...  but should this whole 'conditions' section be inside
variables? I would have expected 'defines' and 'compile_flags' at least to be
outside of variables, with variables inside 'conditions' (instead of the other
way around). And then, I suspect:
'clang': 1
would go inside the variables section?

Powered by Google App Engine
This is Rietveld 408576698