Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1305)

Unified Diff: content/public/common/media_stream_request.h

Issue 10912004: Begin adding support for tab mirroring via the MediaStream audio/video capturing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/media_stream_request.h
diff --git a/content/public/common/media_stream_request.h b/content/public/common/media_stream_request.h
index b383a31bb2c659f202b94d70c3da68676fa503cd..71ccfc7f101220a6ad21bb6dad1e88a83a845804 100644
--- a/content/public/common/media_stream_request.h
+++ b/content/public/common/media_stream_request.h
@@ -18,11 +18,23 @@ namespace content {
// Types of media streams.
enum MediaStreamDeviceType {
MEDIA_STREAM_DEVICE_TYPE_NO_SERVICE = 0,
- MEDIA_STREAM_DEVICE_TYPE_AUDIO_CAPTURE,
- MEDIA_STREAM_DEVICE_TYPE_VIDEO_CAPTURE,
+
+ // A user device provided by the operating system (e.g., webcam input).
+ MEDIA_STREAM_DEVICE_TYPE_USER_AUDIO_CAPTURE,
no longer working on chromium 2012/08/31 13:38:22 I know the names have been silly long before, but
miu 2012/09/01 01:32:00 Completely agree! :) Done. I've also shortened
+ MEDIA_STREAM_DEVICE_TYPE_USER_VIDEO_CAPTURE,
no longer working on chromium 2012/08/31 13:38:22 same suggestion for the rest of the enums.
miu 2012/09/01 01:32:00 Done.
+
+ // Mirroring of a browser tab.
+ MEDIA_STREAM_DEVICE_TYPE_TAB_AUDIO_CAPTURE,
+ MEDIA_STREAM_DEVICE_TYPE_TAB_VIDEO_CAPTURE,
+
NUM_MEDIA_STREAM_DEVICE_TYPES
};
+// Convenience predicates to determine whether the given type represents some
+// audio or some video device.
+bool IsAudioMediaStreamDeviceType(MediaStreamDeviceType type);
+bool IsVideoMediaStreamDeviceType(MediaStreamDeviceType type);
+
// TODO(xians): Change the structs to classes.
// Represents one device in a request for media stream(s).
struct CONTENT_EXPORT MediaStreamDevice {

Powered by Google App Engine
This is Rietveld 408576698