chrome/browser/tab_contents/render_view_context_menu.cc - Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix typo Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/printing_layout_browsertest.cc ('k') | chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc

index fc46a87e243e3fdebf7492a7ab6460f6f9fc0f97..a428f3efe9ec4aa921219b539f44ad4a4553a60c 100644

--- a/chrome/browser/tab_contents/render_view_context_menu.cc

+++ b/chrome/browser/tab_contents/render_view_context_menu.cc

@@ -1710,14 +1710,14 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {

case IDC_PRINT:

if (params_.media_type == WebContextMenuData::MediaTypeNone) {

- TabContents* tab_contents =

- TabContents::FromWebContents(source_web_contents_);

- if (!tab_contents)

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(source_web_contents_);

+ if (!print_view_manager)

break;

if (profile_->GetPrefs()->GetBoolean(prefs::kPrintPreviewDisabled)) {

- tab_contents->print_view_manager()->PrintNow();

+ print_view_manager->PrintNow();

} else {

- tab_contents->print_view_manager()->PrintPreviewNow();

+ print_view_manager->PrintPreviewNow();

}

} else {

rvh->Send(new PrintMsg_PrintNodeUnderContextMenu(rvh->GetRoutingID()));