Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 10911350: Update Windows System Monitor Removable Device Impl. (Closed)

Created:
8 years, 3 months ago by vandebo (ex-Chrome)
Modified:
8 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Update Windows System Monitor Removable Device Impl. Change the notifier to notify about all removable devices, to get more device information and to fetch the already connected removable devices. Implement the Windows specific part of MediaStorageUtil Original CL: http://codereview.chromium.org/10911234 BUG=144496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157290

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -174 lines) Patch
M chrome/browser/chrome_browser_main_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/system_monitor/media_storage_util.cc View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_window_win.h View 1 chunk +54 lines, -22 lines 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_window_win.cc View 1 2 chunks +255 lines, -109 lines 0 comments Download
M chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc View 9 chunks +162 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vandebo (ex-Chrome)
https://codereview.chromium.org/10911350/diff/1/chrome/browser/system_monitor/media_storage_util.cc File chrome/browser/system_monitor/media_storage_util.cc (right): https://codereview.chromium.org/10911350/diff/1/chrome/browser/system_monitor/media_storage_util.cc#newcode224 chrome/browser/system_monitor/media_storage_util.cc:224: #if (defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_WIN)) && \ This ...
8 years, 3 months ago (2012-09-18 00:51:43 UTC) #1
Lei Zhang
lgtm
8 years, 3 months ago (2012-09-18 00:52:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10911350/1
8 years, 3 months ago (2012-09-18 01:24:33 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/system_monitor/removable_device_notifications_window_win.cc: While running patch -p1 --forward --force; patching file chrome/browser/system_monitor/removable_device_notifications_window_win.cc ...
8 years, 3 months ago (2012-09-18 01:24:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10911350/1
8 years, 3 months ago (2012-09-18 01:34:54 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/browser/system_monitor/removable_device_notifications_window_win.cc: While running patch -p1 --forward --force; patching file chrome/browser/system_monitor/removable_device_notifications_window_win.cc ...
8 years, 3 months ago (2012-09-18 01:34:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10911350/9001
8 years, 3 months ago (2012-09-18 02:19:03 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 3 months ago (2012-09-18 02:22:28 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-18 03:21:51 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698