Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10911345: Remove TODO I have already done. (Closed)

Created:
8 years, 3 months ago by gab
Modified:
8 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Remove TODO I have already done. I had left a TODO for myself, but ended up doing it in the same CL in http://crrev.com/156250 NOTRY=True BUG=148539 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M base/win/shortcut.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gab
Sir, PTAL, I actually did this (by changing win_util.cc) in the same CL, but forgot ...
8 years, 3 months ago (2012-09-17 21:36:33 UTC) #1
robertshield
lgtm
8 years, 3 months ago (2012-09-17 23:08:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10911345/1
8 years, 3 months ago (2012-09-17 23:09:19 UTC) #3
commit-bot: I haz the power
Presubmit check for 10911345-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-17 23:09:22 UTC) #4
gab
@willchan for OWNERS, feel free to CQ.
8 years, 3 months ago (2012-09-18 14:22:16 UTC) #5
gab
On 2012/09/18 14:22:16, gab wrote: > @willchan for OWNERS, feel free to CQ. @willchan: ping
8 years, 3 months ago (2012-09-20 15:11:31 UTC) #6
willchan no longer on Chromium
lgtm
8 years, 3 months ago (2012-09-20 16:13:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10911345/1
8 years, 3 months ago (2012-09-20 16:13:34 UTC) #8
willchan no longer on Chromium
Sorry, this fell through the cracks. On Thu, Sep 20, 2012 at 8:11 AM, <gab@chromium.org> ...
8 years, 3 months ago (2012-09-20 16:13:37 UTC) #9
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 16:25:04 UTC) #10
Change committed as 157780

Powered by Google App Engine
This is Rietveld 408576698