Issue 10911334: Fix misplaced assert in heap.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911334: Fix misplaced assert in heap.cc. (Closed)

Created:
8 years, 3 months ago by Erik Corry

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix misplaced assert in heap.cc. BUG=v8:2336 Committed: https://code.google.com/p/v8/source/detail?r=12528

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -1 line)			Patch
M	src/heap.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
A	test/mjsunit/bugs/bug-2337.js	View	1 2 3	1 chunk	+53 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-2336.js	View	1 2	1 chunk	+53 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one idea, feel free to ignore). https://chromiumcodereview.appspot.com/10911334/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10911334/diff/1/src/heap.cc#newcode624 src/heap.cc:624: // ...

8 years, 3 months ago (2012-09-17 09:28:39 UTC) #2

Still LGTM.

Expand Messages | Collapse Messages

Issue 10911334: Fix misplaced assert in heap.cc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages