Normalization of patch signatures.

lib/core/date.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Dart core library.
 
 /**
  * Date is the public interface to a point in time.
  *
  * It can represent time values that are at a distance of at most
@@ skipping 30 matching lines @@
   /**
    * Constructs a [Date] instance based on the individual parts. The date is
    * in the local time zone if [isUtc] is false.
    *
    * [month] and [day] are one-based. For example
    * [:new Date(1938, 1, 10)] represents the 10th of January 1938.
    */
   // TODO(floitsch): the spec allows default values in interfaces, but our
   // tools don't yet. Eventually we want to have default values here.
   Date(int year,
-       [int month,
-        int day,
-        int hour,
-        int minute,
-        int second,
-        int millisecond,
-        bool isUtc]);
+       [int month = 1,

[Mads Ager (google), 2012/09/17 05:52:56]

Are default values allowed in interfaces now? They used to not be. Do you need
to change the interface here? This is not what is being patched.
DateImplementation is what is being patched (at this point).

[Lasse Reichstein Nielsen, 2012/09/17 11:32:43]

It's allowed since v. 0.09.
But it's true that it's not related to patching.

I like the default values. We will change the interface to an abstract class
Real Soon Now, and probably to a normal factory constructor to begin with. I.e.,
personally I don't mind that this is changed, even if it's not needed.

[Mads Ager (google), 2012/09/17 11:37:26]

Great, now that it is allowed I'm actually strongly in favor of this change. Not
having the default values in the interface is a mess. Thanks Lasse.

[Johnni Winther, 2012/09/19 09:03:30]

It seems to be allowed now and the TODO above wants it too. But you are right,
it is only needed in DateImplementation.

+        int day = 1,
+        int hour = 0,
+        int minute = 0,
+        int second = 0,
+        int millisecond = 0,
+        bool isUtc = false]);
 
   /**
    * Constructs a new [Date] instance with current date time value in the
    * local time zone.
    */
   Date.now();
 
   /**
    * Constructs a new [Date] instance based on [formattedString].
    */
@@ skipping 140 matching lines @@
   /**
    * Returns a new [Date] with the [duration] subtracted from this instance.
    */
   Date subtract(Duration duration);
 
   /**
    * Returns a [Duration] with the difference of [:this:] and [other].
    */
   Duration difference(Date other);
 }