Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 10911305: Replace r12503. Explicitly check toString() for exception in d8's print(). (Closed)

Created:
8 years, 3 months ago by Yang
Modified:
8 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Replace r12503. Explicitly check toString() for exception in d8's print(). R=jkummerow@chromium.org BUG=v8:2317 Committed: https://code.google.com/p/v8/source/detail?r=12507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -34 lines) Patch
M src/api.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M src/d8.cc View 1 chunk +7 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
8 years, 3 months ago (2012-09-14 10:11:50 UTC) #1
Jakob Kummerow
8 years, 3 months ago (2012-09-14 11:34:02 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698