Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10911288: Merges manifest changes from ChromeVox from upstream. (Closed)

Created:
8 years, 3 months ago by David Tseng
Modified:
8 years, 3 months ago
Reviewers:
dmazzoni, zel
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Merges manifest changes from ChromeVox upstream. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/chromeos/access_chromevox/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
David Tseng
8 years, 3 months ago (2012-09-13 17:08:47 UTC) #1
dmazzoni
lgtm
8 years, 3 months ago (2012-09-13 17:14:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/10911288/1
8 years, 3 months ago (2012-09-13 17:56:57 UTC) #3
commit-bot: I haz the power
Presubmit check for 10911288-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-13 17:57:02 UTC) #4
David Tseng
+ zelidrag for OWNERS approval. On Thu, Sep 13, 2012 at 10:57 AM, <commit-bot@chromium.org> wrote: ...
8 years, 3 months ago (2012-09-13 18:00:21 UTC) #5
zel
lgtm
8 years, 3 months ago (2012-09-13 18:13:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/10911288/1
8 years, 3 months ago (2012-09-13 18:21:26 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 20:50:09 UTC) #8
Change committed as 156626

Powered by Google App Engine
This is Rietveld 408576698