Make spin button accessible on Mac.

Make spin button accessible on Mac.

I mapped a spin button to a vertical slider, which causes VoiceOver to
expect the appropriate range attributes - and then gave it a role description of
"spin button" and an orientation of "vertical", so hopefully users will
be able to figure it out.

I also filled in the remaining range attributes that weren't implemented yet,
which also improves sliders, scroll bars, and progress bars.

BUG=130430
TEST=Visit a webpage with an ARIA spinbutton with VoiceOver on.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156881

[dmazzoni, 2012-09-13 16:44:25]

dtseng: review (should be quick)
tony: OWNERS approval for new string in webkit/glue

[tony, 2012-09-13 18:25:49]

webkit LGTM

[David Tseng, 2012-09-13 19:00:57]

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
content/browser/accessibility/browser_accessibility_cocoa.mm:152: {
AccessibilityNodeData::ROLE_SPIN_BUTTON, NSAccessibilitySliderRole },
I think we actually want to map to NSAccessibilityIncrementorRole.

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
content/browser/accessibility/browser_accessibility_cocoa.mm:1045: // Performs
the given accessibilty action on the webkit accessibility object
If we go with NSAccessibilityIncrementorRole, hook up
NSAccessibilityIncrementAction, NSAccessibilityDecrementAction.

http://codereview.chromium.org/10911287/diff/1/webkit/glue/webkit_strings.grd
File webkit/glue/webkit_strings.grd (right):

http://codereview.chromium.org/10911287/diff/1/webkit/glue/webkit_strings.grd...
webkit/glue/webkit_strings.grd:298: spin button
OS X actually calls this a "stepper".

[dmazzoni, 2012-09-13 19:32:29]

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
content/browser/accessibility/browser_accessibility_cocoa.mm:152: {
AccessibilityNodeData::ROLE_SPIN_BUTTON, NSAccessibilitySliderRole },
On 2012/09/13 19:00:57, David Tseng wrote:
> I think we actually want to map to NSAccessibilityIncrementorRole.

That's what WebKit maps it to on Mac, but it doesn't work.
NSAccessibilityIncrementorRole is intended for the plus button next to a
Mac-native spin button - and NSAccessibilityIncrementorRole is intended for the
minus button. In a native spin button, the text field is just a text field.

As far as I can tell, there's no native Mac control that corresponds to a spin
button on Windows, so this is the closest approximation I could find that I can
actually get to work.

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
content/browser/accessibility/browser_accessibility_cocoa.mm:1045: // Performs
the given accessibilty action on the webkit accessibility object
On 2012/09/13 19:00:57, David Tseng wrote:
> If we go with NSAccessibilityIncrementorRole, hook up
> NSAccessibilityIncrementAction, NSAccessibilityDecrementAction.

Right now that's impossible, there's no way for a screen reader to modify the
value of an ARIA control. The Indie UI proposal will fix this; it will let web
apps listen to high-level actions like "increment", "press", and "jump to last
item" rather than listening to key events. The draft is expected soon and then
we can start implementing it.

[David Tseng, 2012-09-13 22:00:28]

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
content/browser/accessibility/browser_accessibility_cocoa.mm:152: {
AccessibilityNodeData::ROLE_SPIN_BUTTON, NSAccessibilitySliderRole },
On 2012/09/13 19:32:29, Dominic Mazzoni wrote:

Actually, I just tried an example on Mac and the mapping is to a progress
indicator.

http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/...
content/browser/accessibility/browser_accessibility_cocoa.mm:505: // of "spin
button".
Can we at least call it something more familiar like "stepper" so that users
will know it is meant to be adjusted and not pressed?

I know there's lack of standardization here (i.e. Jaws calls role=spinbutton
"spin box").

[David Tseng, 2012-09-13 22:07:04]

lgtm

Considering that this is probably a fix before further work from the wg's
comes through.


On Thu, Sep 13, 2012 at 3:00 PM, <dtseng@chromium.org> wrote:

>
> http://codereview.chromium.**org/10911287/diff/1/content/**
>
browser/accessibility/browser_**accessibility_cocoa.mm<http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm>
> File
content/browser/accessibility/**browser_accessibility_cocoa.mm<http://browser_accessibility_cocoa.mm>
> (right):
>
> http://codereview.chromium.**org/10911287/diff/1/content/**
>
browser/accessibility/browser_**accessibility_cocoa.mm#**newcode152<http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode152>
>
content/browser/accessibility/**browser_accessibility_cocoa.**mm:152<http://browser_accessibility_cocoa.mm:152>:
> {
> AccessibilityNodeData::ROLE_**SPIN_BUTTON, NSAccessibilitySliderRole },
> On 2012/09/13 19:32:29, Dominic Mazzoni wrote:
>
> Actually, I just tried an example on Mac and the mapping is to a
> progress indicator.
>
> http://codereview.chromium.**org/10911287/diff/1/content/**
>
browser/accessibility/browser_**accessibility_cocoa.mm#**newcode505<http://codereview.chromium.org/10911287/diff/1/content/browser/accessibility/browser_accessibility_cocoa.mm#newcode505>
>
content/browser/accessibility/**browser_accessibility_cocoa.**mm:505<http://browser_accessibility_cocoa.mm:505>:
> // of
> "spin button".
> Can we at least call it something more familiar like "stepper" so that
> users will know it is meant to be adjusted and not pressed?
>
> I know there's lack of standardization here (i.e. Jaws calls
> role=spinbutton "spin box").
>
>
http://codereview.chromium.**org/10911287/<http://codereview.chromium.org/109...
>

[dmazzoni, 2012-09-13 22:22:36]

On 2012/09/13 22:00:28, David Tseng wrote:
> Can we at least call it something more familiar like "stepper" so that users
> will know it is meant to be adjusted and not pressed?

Yes! Thanks, I was looking for the equivalent native control but I couldn't find
it. Stepper seems to be what VoiceOver calls it.

- Dominic

[commit-bot: I haz the power, 2012-09-14 07:42:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10911287/2002

[commit-bot: I haz the power, 2012-09-14 18:52:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10911287/11001

[commit-bot: I haz the power, 2012-09-14 20:48:05]

Change committed as 156881