Issue 10911269: Fix compilation problem for clang-3.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911269: Fix compilation problem for clang-3.0. (Closed)

Created:
8 years, 3 months ago by Han

Modified:
8 years, 3 months ago

Reviewers:
Seigo Nonaka, nona, zork

CC:
carrot_google.com, c-compiler-chrome_google.com, chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix compilation problem for clang-3.0. The clang error is - chrome/browser/chromeos/input_method/ibus_controller_impl.cc:319:15: error: function 'PrintPropList' has internal linkage but is not defined [-Werror] std::string PrintPropList(IBusPropList *prop_list, int tree_level); ^chrome/browser/chromeos/input_method/ibus_controller_impl.cc:350:13: note: used here stream << PrintPropList(ibus_property_get_sub_props(prop), tree_level + 1); Fixed by moving proto-type out of function body. BUG=None TEST=Built using clang Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158339

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/input_method/ibus_controller_impl.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shenhan@google.com/10911269/1

8 years, 3 months ago (2012-09-24 16:41:47 UTC) #3

Change committed as 158339

Expand Messages | Collapse Messages