cc: Scheduler will never process a commit until it receives a vsync tick.

cc/CCSchedulerTest.cpp

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "CCScheduler.h"
 
 #include "CCSchedulerTestCommon.h"
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 #include <wtf/OwnPtr.h>
 
 using namespace WTF;
 using namespace WebCore;
 using namespace WebKitTests;
 
 namespace {
 
 class FakeCCSchedulerClient : public CCSchedulerClient {
 public:
     FakeCCSchedulerClient() { reset(); }
     void reset()
     {
         m_actions.clear();
-        m_hasMoreResourceUpdates = false;
         m_drawWillHappen = true;
         m_swapWillHappenIfDrawHappens = true;
         m_numDraws = 0;
     }
 
-    void setHasMoreResourceUpdates(bool b) { m_hasMoreResourceUpdates = b; }
-
     int numDraws() const { return m_numDraws; }
     int numActions() const { return static_cast<int>(m_actions.size()); }
     const char* action(int i) const { return m_actions[i]; }
 
     bool hasAction(const char* action) const
     {
         for (size_t i = 0; i < m_actions.size(); i++)
             if (!strcmp(m_actions[i], action))
                 return true;
         return false;
     }
 
-    virtual bool hasMoreResourceUpdates() const OVERRIDE { return m_hasMoreResourceUpdates; }
-
     virtual void scheduledActionBeginFrame() OVERRIDE { m_actions.push_back("scheduledActionBeginFrame"); }
     virtual CCScheduledActionDrawAndSwapResult scheduledActionDrawAndSwapIfPossible() OVERRIDE
     {
         m_actions.push_back("scheduledActionDrawAndSwapIfPossible");
         m_numDraws++;
         return CCScheduledActionDrawAndSwapResult(m_drawWillHappen, m_drawWillHappen && m_swapWillHappenIfDrawHappens);
     }
 
     virtual CCScheduledActionDrawAndSwapResult scheduledActionDrawAndSwapForced() OVERRIDE
     {
@@ skipping 26 matching lines @@
     scheduler->setVisible(true);
     scheduler->setCanDraw(true);
 
     // SetNeedsCommit should begin the frame.
     scheduler->setNeedsCommit();
     EXPECT_EQ(1, client.numActions());
     EXPECT_STREQ("scheduledActionBeginFrame", client.action(0));
     EXPECT_FALSE(timeSource->active());
     client.reset();
 
-    // Since, hasMoreResourceUpdates is set to false,
+    // Since, hasResourceUpdates is false,
     // beginFrameComplete should commit
-    scheduler->beginFrameComplete();
+    scheduler->beginFrameComplete(false);
     EXPECT_EQ(1, client.numActions());
     EXPECT_STREQ("scheduledActionCommit", client.action(0));
     EXPECT_TRUE(timeSource->active());
     client.reset();
 
     // Tick should draw.
     timeSource->tick();
     EXPECT_EQ(1, client.numActions());
     EXPECT_STREQ("scheduledActionDrawAndSwapIfPossible", client.action(0));
     EXPECT_FALSE(timeSource->active());
@@ skipping 14 matching lines @@
 
     // SetNedsCommit should begin the frame.
     scheduler->setNeedsCommit();
     EXPECT_EQ(1, client.numActions());
     EXPECT_STREQ("scheduledActionBeginFrame", client.action(0));
     client.reset();
 
     // Now setNeedsCommit again. Calling here means we need a second frame.
     scheduler->setNeedsCommit();
 
-    // Since, hasMoreResourceUpdates is set to false, and another commit is
+    // Since, hasResourceUpdates is false, and another commit is
     // needed, beginFrameComplete should commit, then begin another frame.
-    scheduler->beginFrameComplete();
+    scheduler->beginFrameComplete(false);
     EXPECT_EQ(1, client.numActions());
     EXPECT_STREQ("scheduledActionCommit", client.action(0));
     client.reset();
 
     // Tick should draw but then begin another frame.
     timeSource->tick();
     EXPECT_FALSE(timeSource->active());
     EXPECT_EQ(2, client.numActions());
     EXPECT_STREQ("scheduledActionDrawAndSwapIfPossible", client.action(0));
     EXPECT_STREQ("scheduledActionBeginFrame", client.action(1));
@@ skipping 13 matching lines @@
     scheduler->setMainThreadNeedsLayerTextures();
     EXPECT_EQ(2, client.numActions());
     EXPECT_STREQ("scheduledActionBeginFrame", client.action(0));
     EXPECT_STREQ("scheduledActionAcquireLayerTexturesForMainThread", client.action(1));
     client.reset();
 
     // Compositor not scheduled to draw because textures are locked by main thread
     EXPECT_FALSE(timeSource->active());
 
     // Trigger the commit
-    scheduler->beginFrameComplete();
+    scheduler->beginFrameComplete(false);
     EXPECT_TRUE(timeSource->active());
     client.reset();
 
     // Between commit and draw, texture acquisition for main thread delayed,
     // and main thread blocks.
     scheduler->setMainThreadNeedsLayerTextures();
     EXPECT_EQ(0, client.numActions());
     client.reset();
 
     // Once compositor draw complete, the delayed texture acquisition fires.
     timeSource->tick();
     EXPECT_EQ(3, client.numActions());
     EXPECT_STREQ("scheduledActionDrawAndSwapIfPossible", client.action(0));
     EXPECT_STREQ("scheduledActionAcquireLayerTexturesForMainThread", client.action(1));
     EXPECT_STREQ("scheduledActionBeginFrame", client.action(2));
     client.reset();
 }
 
 TEST(CCSchedulerTest, VisibilitySwitchWithTextureAcquisition)
 {
     FakeCCSchedulerClient client;
     RefPtr<FakeCCTimeSource> timeSource = adoptRef(new FakeCCTimeSource());
     OwnPtr<CCScheduler> scheduler = CCScheduler::create(&client, adoptPtr(new CCFrameRateController(timeSource)));
     scheduler->setCanBeginFrame(true);
     scheduler->setVisible(true);
     scheduler->setCanDraw(true);
 
     scheduler->setNeedsCommit();
-    scheduler->beginFrameComplete();
+    scheduler->beginFrameComplete(false);
     scheduler->setMainThreadNeedsLayerTextures();
     client.reset();
     // Verify that pending texture acquisition fires when visibility
     // is lost in order to avoid a deadlock.
     scheduler->setVisible(false);
     EXPECT_EQ(1, client.numActions());
     EXPECT_STREQ("scheduledActionAcquireLayerTexturesForMainThread", client.action(0));
     client.reset();
 
     // Regaining visibility with textures acquired by main thread while
@@ skipping 151 matching lines @@
 
     scheduler->setNeedsRedraw();
     EXPECT_TRUE(scheduler->redrawPending());
     EXPECT_EQ(0, client.numDraws());
     EXPECT_TRUE(timeSource->active());
 
     timeSource->tick();
     EXPECT_FALSE(timeSource->active());
     EXPECT_EQ(1, client.numDraws());
     EXPECT_TRUE(scheduler->commitPending());
-    scheduler->beginFrameComplete();
+    scheduler->beginFrameComplete(false);
 
     timeSource->tick();
     EXPECT_EQ(2, client.numDraws());
     EXPECT_FALSE(timeSource->active());
     EXPECT_FALSE(scheduler->redrawPending());
 }
 
 // Tests that when a draw fails then the pending commit should not be dropped.
 TEST(CCSchedulerTest, RequestCommitInsideFailedDraw)
 {
@@ skipping 90 matching lines @@
     // Get the compositor to do a scheduledActionDrawAndSwapForced.
     scheduler->setNeedsRedraw();
     scheduler->setNeedsForcedRedraw();
     EXPECT_TRUE(client.hasAction("scheduledActionDrawAndSwapForced"));
 
     // We should not have told the frame rate controller that we began a frame.
     EXPECT_EQ(0, controllerPtr->numFramesPending());
 }
 
 }