Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10911244: Have a clearer error message for Android's GetMimeTypeFromExtension (Closed)

Created:
8 years, 3 months ago by Peter Beverloo
Modified:
8 years, 3 months ago
Reviewers:
bulach, Yaron
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Have a clearer error message for Android's GetMimeTypeFromExtension The warning is triggered on various layout tests for WebKit, so having a clearer error showing the extension for which we can't get a mime type helps in finding the right solution. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M net/android/network_library.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Peter Beverloo
+bulach for review +yfriedman for OWNERS
8 years, 3 months ago (2012-09-12 12:53:36 UTC) #1
bulach
lgtm
8 years, 3 months ago (2012-09-12 13:03:06 UTC) #2
Yaron
lgtm
8 years, 3 months ago (2012-09-12 15:51:47 UTC) #3
Peter Beverloo
On 2012/09/12 15:51:47, Yaron wrote: > lgtm Thank you!
8 years, 3 months ago (2012-09-12 15:52:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/10911244/1
8 years, 3 months ago (2012-09-12 15:52:39 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-12 20:37:50 UTC) #6
Change committed as 156369

Powered by Google App Engine
This is Rietveld 408576698