Show proper title for spinner dialog.

Show proper title for spinner dialog.

"Advanced sync setup" is used for the title of spinner dialog, but
"Please wait..." sounds better.

BUG=147760
TEST=Disable sync from google.com/dashboard, then "Set up Sync" from chrome://settings


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157371

[kochi, 2012-09-11 06:10:00]

Hi Drew,

Could you review this?

James,

Could you review for OWNERS?

[kochi, 2012-09-11 06:16:42]

In case Drew's on leave - Nicolas, could you take a look?

Thanks,

[Nicolas Zea, 2012-09-11 12:58:30]

http://codereview.chromium.org/10911203/diff/1/chrome/browser/ui/webui/sync_s...
File chrome/browser/ui/webui/sync_setup_handler.cc (right):

http://codereview.chromium.org/10911203/diff/1/chrome/browser/ui/webui/sync_s...
chrome/browser/ui/webui/sync_setup_handler.cc:287: { "syncSetupConfigureTitle",
IDS_SYNC_SETUP_CONFIGURE_TITLE },
is this still used or can it be removed?

[kochi, 2012-09-11 13:40:12]

http://codereview.chromium.org/10911203/diff/1/chrome/browser/ui/webui/sync_s...
File chrome/browser/ui/webui/sync_setup_handler.cc (right):

http://codereview.chromium.org/10911203/diff/1/chrome/browser/ui/webui/sync_s...
chrome/browser/ui/webui/sync_setup_handler.cc:287: { "syncSetupConfigureTitle",
IDS_SYNC_SETUP_CONFIGURE_TITLE },
On 2012/09/11 12:58:30, nzea wrote:
> is this still used or can it be removed?

This is still used for the "Advanced sync configuration" dialog.

[Nicolas Zea, 2012-09-11 13:45:25]

I see. LGTM

[James Hawkins, 2012-09-11 16:03:52]

Can you please get this UI change approved by a UI lead?

[kochi, 2012-09-12 01:57:29]

On 2012/09/11 16:03:52, James Hawkins wrote:
> Can you please get this UI change approved by a UI lead?

Sent a request for review to Chrome UI leads.
Thanks for the suggestion.

[kochi, 2012-09-12 17:13:51]

On 2012/09/12 01:57:29, Takayoshi Kochi wrote:
> On 2012/09/11 16:03:52, James Hawkins wrote:
> > Can you please get this UI change approved by a UI lead?
> 
> Sent a request for review to Chrome UI leads.
> Thanks for the suggestion.

Got OK from glen@.

[kochi, 2012-09-13 05:03:04]

Hi James,

Can I commit this?

On 2012/09/12 17:13:51, Takayoshi Kochi wrote:
> On 2012/09/12 01:57:29, Takayoshi Kochi wrote:
> > On 2012/09/11 16:03:52, James Hawkins wrote:
> > > Can you please get this UI change approved by a UI lead?
> > 
> > Sent a request for review to Chrome UI leads.
> > Thanks for the suggestion.
> 
> Got OK from glen@.

[kochi, 2012-09-14 02:29:27]

Ping?

On 2012/09/13 05:03:04, Takayoshi Kochi wrote:
> Hi James,
> 
> Can I commit this?
> 
> On 2012/09/12 17:13:51, Takayoshi Kochi wrote:
> > On 2012/09/12 01:57:29, Takayoshi Kochi wrote:
> > > On 2012/09/11 16:03:52, James Hawkins wrote:
> > > > Can you please get this UI change approved by a UI lead?
> > > 
> > > Sent a request for review to Chrome UI leads.
> > > Thanks for the suggestion.
> > 
> > Got OK from glen@.

[kochi, 2012-09-15 16:45:05]

In case James is not available - added arv@ and estade@.

Can you check resources OWNERS?
I'd like to get this in before M23 string freeze.

I have already got OK from Chrome UI leads (glen@).


On 2012/09/14 02:29:27, Takayoshi Kochi wrote:
> Ping?
> 
> On 2012/09/13 05:03:04, Takayoshi Kochi wrote:
> > Hi James,
> > 
> > Can I commit this?
> > 
> > On 2012/09/12 17:13:51, Takayoshi Kochi wrote:
> > > On 2012/09/12 01:57:29, Takayoshi Kochi wrote:
> > > > On 2012/09/11 16:03:52, James Hawkins wrote:
> > > > > Can you please get this UI change approved by a UI lead?
> > > > 
> > > > Sent a request for review to Chrome UI leads.
> > > > Thanks for the suggestion.
> > > 
> > > Got OK from glen@.

[Evan Stade, 2012-09-17 09:38:35]

lgtm

[Andrew T Wilson (Slow), 2012-09-17 23:15:09]

lgtm

[commit-bot: I haz the power, 2012-09-18 07:08:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10911203/1

[commit-bot: I haz the power, 2012-09-18 07:22:13]

Retried try job too often for step(s) build

[commit-bot: I haz the power, 2012-09-18 07:51:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10911203/12003

[commit-bot: I haz the power, 2012-09-18 15:14:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/10911203/12003

[commit-bot: I haz the power, 2012-09-18 17:11:02]

Change committed as 157371