Revert 155950 - Add initial Chromium TestShell support for Android

Revert 155950 - Add initial Chromium TestShell support for Android

This makes check_deps fail on linux thusly:

Using base directory: src
Checking: src
WARNING: no package definition found in src/content/test/data/plugin/java_applet.java
WARNING: no package definition found in src/content/test/data/plugin/applet-tests/cookies/CookieTest.java
WARNING: no package definition found in src/content/test/data/plugin/applet-tests/authenticator/AuthenticatorTest.java
WARNING: multiple definitions of com.example.HelloLicenseServlet:
    src/chrome/common/extensions/docs/examples/apps/hello-java/workspace/HelloLicense/src/com/example/HelloLicenseServlet.java
    src/chrome/common/extensions/docs/examples/apps/hello-java/HelloLicenseServlet.java


ERROR in src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java
  Illegal include: "content/public/android/java/src/org/chromium/content/app/LibraryLoader.java"
    Because of no rule applying.
  Illegal include: "content/public/android/java/src/org/chromium/content/browser/ContentView.java"
    Because of no rule applying.
  Illegal include: "content/public/android/java/src/org/chromium/content/common/CommandLine.java"
    Because of no rule applying.

ERROR in src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellApplication.java
  Illegal include: "content/public/android/java/src/org/chromium/content/app/LibraryLoader.java"
    Because of no rule applying.
  Illegal include: "content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java"
    Because of no rule applying.

FAILED

Add a build target and tie it into android_all.  This will build and link
Chrome code for a test apk for Android.  When it runs it properly
loads the library but crashes.  Will fix the crashes in subsequent
patches, but can fork that work after this is in.

BUG=136786
Review URL: https://chromiumcodereview.appspot.com/10918113

TBR=dtrainor@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155958

[Nico, 2012-09-11 06:07:10]

Also caused this on the android bot:

BUILD FAILED
/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/sdk/tools/ant/build.xml:919:
The following error occurred while executing this line:
/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/sdk/tools/ant/build.xml:930:
The following error occurred while executing this line:
/b/build/slave/Android_Builder__dbg_/build/src/third_party/android_tools/sdk/tools/ant/build.xml:295:
com.android.sdklib.build.ApkCreationException: Failed to create
'${out.dir}/ChromiumTestShell-debug-unsigned.apks': No such file or
directory
	at com.android.sdklib.build.ApkBuilder.checkOutputFile(ApkBuilder.java:903)
	at com.android.sdklib.build.ApkBuilder.init(ApkBuilder.java:435)
	at com.android.sdklib.build.ApkBuilder.<init>(ApkBuilder.java:394)
	at com.android.ant.ApkBuilderTask.execute(ApkBuilderTask.java:334)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:398)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
	at com.android.ant.IfElseTask.execute(IfElseTask.java:124)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
	at com.android.ant.IfElseTask.execute(IfElseTask.java:124)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:398)
	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:291)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
	at org.apache.tools.ant.Task.perform(Task.java:348)
	at org.apache.tools.ant.Target.execute(Target.java:390)
	at org.apache.tools.ant.Target.performTasks(Target.java:411)
	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1360)
	at org.apache.tools.ant.Project.executeTarget(Project.java:1329)
	at
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
	at org.apache.tools.ant.Project.executeTargets(Project.java:1212)
	at org.apache.tools.ant.Main.runBuild(Main.java:801)
	at org.apache.tools.ant.Main.startAnt(Main.java:218)
	at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
	at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)


On Tue, Sep 11, 2012 at 3:05 PM,  <thakis@chromium.org> wrote:
> Reviewers: dtrainor,
>
> Description:
> Revert 155950 - Add initial Chromium TestShell support for Android
>
> This makes check_deps fail on linux thusly:
>
> Using base directory: src
> Checking: src
> WARNING: no package definition found in
> src/content/test/data/plugin/java_applet.java
> WARNING: no package definition found in
> src/content/test/data/plugin/applet-tests/cookies/CookieTest.java
> WARNING: no package definition found in
>
src/content/test/data/plugin/applet-tests/authenticator/AuthenticatorTest.java
> WARNING: multiple definitions of com.example.HelloLicenseServlet:
>
>
src/chrome/common/extensions/docs/examples/apps/hello-java/workspace/HelloLicense/src/com/example/HelloLicenseServlet.java
>
>
src/chrome/common/extensions/docs/examples/apps/hello-java/HelloLicenseServlet.java
>
>
> ERROR in
>
src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java
>   Illegal include:
> "content/public/android/java/src/org/chromium/content/app/LibraryLoader.java"
>     Because of no rule applying.
>   Illegal include:
>
"content/public/android/java/src/org/chromium/content/browser/ContentView.java"
>     Because of no rule applying.
>   Illegal include:
>
"content/public/android/java/src/org/chromium/content/common/CommandLine.java"
>     Because of no rule applying.
>
> ERROR in
>
src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellApplication.java
>   Illegal include:
> "content/public/android/java/src/org/chromium/content/app/LibraryLoader.java"
>     Because of no rule applying.
>   Illegal include:
>
"content/public/android/java/src/org/chromium/content/browser/ResourceExtractor.java"
>     Because of no rule applying.
>
> FAILED
>
> Add a build target and tie it into android_all.  This will build and link
> Chrome code for a test apk for Android.  When it runs it properly
> loads the library but crashes.  Will fix the crashes in subsequent
> patches, but can fork that work after this is in.
>
> BUG=136786
>
>
> Review URL: https://chromiumcodereview.appspot.com/10918113
>
> TBR=dtrainor@chromium.org
>
> Please review this at https://chromiumcodereview.appspot.com/10911202/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>   M     build/all_android.gyp
>   D     chrome/android/testshell/DEPS
>   D     chrome/android/testshell/chrome_main_delegate_testshell_android.h
>   D     chrome/android/testshell/chrome_main_delegate_testshell_android.cc
>   D     chrome/android/testshell/java/AndroidManifest.xml
>   D     chrome/android/testshell/java/chromium_testshell_apk.xml
>   D
>
chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java
>   D
>
chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellApplication.java
>   D     chrome/android/testshell/testshell_entry_point.cc
>   D     chrome/android/testshell/testshell_stubs.cc
>   M     chrome/app/DEPS
>   D     chrome/app/android/chrome_android_initializer.h
>   D     chrome/app/android/chrome_android_initializer.cc
>   D     chrome/app/android/chrome_main_delegate_android.h
>   D     chrome/app/android/chrome_main_delegate_android.cc
>   MM    chrome/app/chrome_main_delegate.h
>   M     chrome/app/chrome_main_delegate.cc
>   M     chrome/browser/chrome_browser_main_android.cc
>   M     chrome/chrome.gyp
>   D     chrome/chrome_android.gypi
>   D     chrome/chrome_android_paks.gypi
>   M     chrome/common/chrome_paths_android.cc
>
>

[David Trainor- moved to gerrit, 2012-09-11 06:11:22]

LGTM.  Thanks for catching this.  Will fix.