Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3720)

Unified Diff: chrome/browser/autocomplete/shortcuts_provider_unittest.cc

Issue 10911188: autocomplete: Add AutocompleteMatch::MergeClassifications() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply more feedback Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/shortcuts_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
index 85a6524ca8dad436a84c786511634fbb3cc828ad..740846ed65874a239916e7b86727fda49311afe2 100644
--- a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
+++ b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc
@@ -506,7 +506,10 @@ TEST_F(ShortcutsProviderTest, ClassifyAllMatchesInString) {
// Extra parens in the next line hack around C++03's "most vexing parse".
class ClassifyTest classify_test5((string16()), ACMatchClassifications());
ACMatchClassifications spans_j = classify_test5.RunTest(ASCIIToUTF16("man"));
- ASSERT_EQ(0U, spans_j.size());
+ ASSERT_EQ(1U, spans_j.size());
+ EXPECT_EQ(0U, spans_j.front().offset);
+ EXPECT_EQ(AutocompleteMatch::ACMatchClassification::NONE,
+ spans_j.front().style);
// Matches which end at beginning of classification merge properly.
matches.clear();
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698