Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 10911187: Re-enable tests disabled for bug 136310 (Closed)

Created:
8 years, 3 months ago by mmenke
Modified:
8 years, 3 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Re-enable most of the tests disabled for bug 136310, the underlying WebKit bug has now been fixed. MultipartResponseTest.SingleVisit is still disabled, since it's still failing for some reason. BUG=136310 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155852

Patch Set 1 #

Patch Set 2 : Disable MultipartResponseTest.SingleVisit again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 3 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mmenke
Looks like MultipartResponseTest.SingleVisit is still failing for some reason. Whether it's for some related reason ...
8 years, 3 months ago (2012-09-10 20:05:24 UTC) #1
Nate Chapin
lgtm
8 years, 3 months ago (2012-09-10 20:09:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10911187/6002
8 years, 3 months ago (2012-09-10 20:15:56 UTC) #3
commit-bot: I haz the power
Presubmit check for 10911187-6002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-10 20:15:58 UTC) #4
mmenke
[+jhawkins] Could you sign off on the changes to chrome/browser/errorpage_browsertest.cc? Thanks.
8 years, 3 months ago (2012-09-10 20:27:01 UTC) #5
James Hawkins
LGTM. This is a TBR-worthy change btw.
8 years, 3 months ago (2012-09-10 20:29:06 UTC) #6
mmenke
On 2012/09/10 20:29:06, James Hawkins wrote: > LGTM. This is a TBR-worthy change btw. I ...
8 years, 3 months ago (2012-09-10 20:30:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10911187/6002
8 years, 3 months ago (2012-09-10 20:30:51 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 22:32:43 UTC) #9
Change committed as 155852

Powered by Google App Engine
This is Rietveld 408576698