Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: tests/compiler/dart2js/gvn_dynamic_field_get_test.dart

Issue 10911181: Collect getters in a FunctionSet while resolving. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dartdoc/mirrors/dart2js_mirror.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/gvn_dynamic_field_get_test.dart
===================================================================
--- tests/compiler/dart2js/gvn_dynamic_field_get_test.dart (revision 0)
+++ tests/compiler/dart2js/gvn_dynamic_field_get_test.dart (revision 0)
@@ -0,0 +1,37 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+// Test that dart2js gvns dynamic getters that don't have side
+// effects.
+
+#import('compiler_helper.dart');
+#import('parser_helper.dart');
+#import('dart:uri');
+
+const String TEST = @"""
+class A {
+ var foo;
+ bar(a) {
+ return a.foo + a.foo;
+ }
+}
+
+main() {
+ new A().bar(new Object());
+}
+""";
+
+main() {
+ Uri uri = new Uri.fromComponents(scheme: 'source');
+ var compiler = compilerFor(TEST, uri);
+ compiler.runCompiler(uri);
+ String generated = compiler.assembledCode;
+ RegExp regexp = const RegExp(@"get\$foo");
+ Iterator matches = regexp.allMatches(generated).iterator();
+ checkNumberOfMatches(matches, 1);
+ var cls = findElement(compiler, 'A');
+ Expect.isNotNull(cls);
+ var element = cls.lookupLocalMember(buildSourceString('foo'));
+ Expect.isNotNull(element);
+ Expect.isFalse(compiler.world.userDefinedGetters.contains(element));
+}
« no previous file with comments | « pkg/dartdoc/mirrors/dart2js_mirror.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698