Collect getters in a FunctionSet while resolving.

lib/compiler/implementation/world.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class World {
-  Compiler compiler;  // Set in populate().
+  final Compiler compiler;
   final Map<ClassElement, Set<ClassElement>> subtypes;
+  final FunctionSet getters;

[ahe, 2012/09/10 15:15:21]

Could you add a method named something like "recordUserDefinedGetter" instead of
using [getters] directly.

[kasperl, 2012/09/11 07:39:11]

Maybe change name to userDefinedGetters or nonTrivialGetters?

[ngeoffray, 2012/09/11 08:51:08]

Done.

[ngeoffray, 2012/09/11 08:51:08]

Done.

 
-  World() : subtypes = new Map<ClassElement, Set<ClassElement>>();
+  World(Compiler compiler)
+      : subtypes = new Map<ClassElement, Set<ClassElement>>(),
+        getters = new FunctionSet(compiler),
+        this.compiler = compiler;
 
-  void populate(Compiler compiler) {
+  void populate() {
     void addSubtypes(ClassElement cls) {
       if (cls.resolutionState != STATE_DONE) {
         compiler.internalErrorOnElement(
             cls, 'Class "${cls.name.slowToString()}" is not resolved.');
       }
       for (DartType type in cls.allSupertypes) {
         Set<Element> subtypesOfCls =
           subtypes.putIfAbsent(type.element, () => new Set<ClassElement>());
         subtypesOfCls.add(cls);
       }
     }
 
     compiler.resolverWorld.instantiatedClasses.forEach(addSubtypes);
-
-    // Mark the world as populated.
-    assert(compiler !== null);
-    this.compiler = compiler;
   }
 
   /**
    * Returns a [MemberSet] that contains the possible targets of the given
    * [selector] on a receiver with the given [type]. This includes all sub
    * types.
    */
   MemberSet _memberSetFor(DartType type, Selector selector) {
     assert(compiler !== null);
     ClassElement cls = type.element;
@@ skipping 57 matching lines @@
   final SourceString name;
 
   MemberSet(SourceString this.name) : elements = new Set<Element>();
 
   void add(Element element) {
     elements.add(element);
   }
 
   bool isEmpty() => elements.isEmpty();
 }