Collect getters in a FunctionSet while resolving.

lib/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 2005 matching lines @@
     // to get the selector from the mapping for the AST selector node.
     Selector selector = (send.asSendSet() === null)
         ? elements.getSelector(send)
         : elements.getSelector(send.selector);
     assert(selector.isGetter());
     SourceString getterName = selector.name;
     Element staticInterceptor = null;
     if (methodInterceptionEnabled) {
       staticInterceptor = interceptors.getStaticGetInterceptor(getterName);
     }
+    bool hasGetter =
+        compiler.world.getters.hasOneElementMatchingSelector(selector);

[ahe, 2012/09/10 17:24:20]

Too many dots.

[ahe, 2012/09/10 17:24:20]

I assume you mean "exactly one"? If so, perhaps adjust the method name.

[ngeoffray, 2012/09/11 08:51:08]

Done.

[ngeoffray, 2012/09/11 08:51:08]

Done.

     if (staticInterceptor != null) {
       HStatic target = new HStatic(staticInterceptor);
       add(target);
       List<HInstruction> inputs = <HInstruction>[target, receiver];
-      push(new HInvokeInterceptor(selector, inputs));
+      push(new HInvokeInterceptor(selector, inputs, hasGetter));
     } else {
-      push(new HInvokeDynamicGetter(selector, null, receiver));
+      push(new HInvokeDynamicGetter(selector, null, receiver, !hasGetter));
     }
   }
 
   void generateGetter(Send send, Element element) {
     if (Elements.isStaticOrTopLevelField(element)) {
       Constant value;
       if (element.isField() && !element.isAssignable()) {
         // A static final or const. Get its constant value and inline it if
         // the value can be compiled eagerly.
         value = compiler.compileVariable(element);
@@ skipping 2050 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }