chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js - Issue 10911158: Pass on download or installation errors from WebstoreInstaller to the CompleteInstall function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

Issue 10911158: Pass on download or installation errors from WebstoreInstaller to the CompleteInstall function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase and rename error204->empty Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

diff --git a/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js b/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

index a08a689c9b4cf04ca1eedfa0abf2882b83ca3b20..29d3900edd7580281c2e1453f7883c1ae8fec264 100644

--- a/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

+++ b/chrome/test/data/extensions/api_test/webstore_private/incorrect_manifest.js

@@ -16,9 +16,8 @@ chrome.webstorePrivate.beginInstallWithManifest3(

function(result) {

assertNoLastError();

assertEq("", result);

+ var expectedError = "Manifest file is invalid.";

chrome.webstorePrivate.completeInstall(extensionId,

- function(){

- assertNoLastError();

- succeed();

- });

+ callbackFail(expectedError));

});

« no previous file with comments | « chrome/test/data/extensions/api_test/webstore_private/empty.js ('k') | no next file » | no next file with comments »