Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4004)

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

Issue 10911158: Pass on download or installation errors from WebstoreInstaller to the CompleteInstall function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and rename error204->empty Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.h
diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h
index 048cad4013f12e137166e1d5316904c2c4272e37..c69afddf361d4ba48c9ad4c41ea7651a1a408902 100644
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h
@@ -149,10 +149,16 @@ class BeginInstallWithManifestFunction
scoped_ptr<ExtensionInstallPrompt> install_prompt_;
};
-class CompleteInstallFunction : public SyncExtensionFunction {
+class CompleteInstallFunction
+ : public AsyncExtensionFunction,
+ public WebstoreInstaller::Delegate {
public:
DECLARE_EXTENSION_FUNCTION_NAME("webstorePrivate.completeInstall");
+ // WebstoreInstaller::Delegate:
+ virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
+ virtual void OnExtensionInstallFailure(const std::string& id,
+ const std::string& error) OVERRIDE;
protected:
virtual ~CompleteInstallFunction() {}
« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698