Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10911157: aura-x11: Make sure the events targetted for root-window reaches all the root-window dispatchers. (Closed)

Created:
8 years, 3 months ago by sadrul
Modified:
8 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

aura-x11: Make sure the events targetted for root-window reaches all the root-window dispatchers. BUG=133721 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155598

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M base/message_pump_aurax11.cc View 6 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
erg@ Please review. willchan@ OWNERS
8 years, 3 months ago (2012-09-07 20:35:02 UTC) #1
Elliot Glaysher
lgtm
8 years, 3 months ago (2012-09-07 20:46:19 UTC) #2
willchan no longer on Chromium
LGTM Btw, are there any ways of writing a test for these behavioral changes? If ...
8 years, 3 months ago (2012-09-07 20:50:47 UTC) #3
sadrul
8 years, 3 months ago (2012-09-08 22:05:05 UTC) #4
On 2012/09/07 20:50:47, willchan wrote:
> LGTM
> 
> Btw, are there any ways of writing a test for these behavioral changes? If
not,
> that's fine, but I just wanted to put you on the spot to assert that it's not
> possible to do so, or to write a test :)

I tried writing a test for this. But looks like right now, it is not possible to
generate synthetic XI2.x events using XSendEvent (the fix is for XI2.x events.
The old code works OK for XI1.x events)

Powered by Google App Engine
This is Rietveld 408576698