Intrinsify Float32Array_getIndexed on IA32 and X64.

runtime/vm/intrinsifier_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // The intrinsic code below is executed before a method has built its frame.
 // The return address is on the stack and the arguments below it.
 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
 // Each intrinsification method returns true if the corresponding
 // Dart method was intrinsified.
 
@@ skipping 539 matching lines @@
 
 
 bool Intrinsifier::Int32Array_getIndexed(Assembler* assembler) {
   return false;
 }
 
 
 bool Intrinsifier::Uint32Array_getIndexed(Assembler* assembler) {
   return false;
 }
 

[srdjan, 2012/09/28 22:42:08]

Two empty lines between functions (here and elsewhere).

+bool Intrinsifier::Float32Array_getIndexed(Assembler* assembler) {
+    Label fall_through;
+    // __ int3();

[srdjan, 2012/09/28 22:42:08]

Indent should be two spaces.

Remove // __ int3();

+    TestByteArrayIndex(assembler, &fall_through);
+    // After TestByteArrayIndex:
+    // * EAX has the base address of the byte array.
+    // * EBX has the index into the array.
+
+    // EBX contains the SMI index which is shifted left by 1.
+    // This shift means we only multiply the index by 2 not 4 (sizeof float).
+    // Load single precision float into XMM7.
+    __ movss(XMM7, FieldAddress(EAX, EBX, TIMES_2,
+                                Float32Array::data_offset()));
+    // Convert into a double precision float.
+    __ cvtss2sd(XMM7, XMM7);
+    // Allocate a double instance.
+    const Class& double_class = Class::Handle(
+                           Isolate::Current()->object_store()->double_class());
+    AssemblerMacros::TryAllocate(assembler,
+                                 double_class,
+                                 &fall_through,
+                                 Assembler::kNearJump, EAX);
+    // Store XMM6 into double instance.
+    __ movsd(FieldAddress(EAX, Double::value_offset()), XMM7);
+    __ ret();
+    __ Bind(&fall_through);
+    return false;
+}
+
+bool Intrinsifier::Float32Array_setIndexed(Assembler* assembler) {
+    return false;
+}
 
 // Tests if two top most arguments are smis, jumps to label not_smi if not.
 // Topmost argument is in EAX.
 static void TestBothArgumentsSmis(Assembler* assembler, Label* not_smi) {
   __ movl(EAX, Address(ESP, + 1 * kWordSize));
   __ movl(EBX, Address(ESP, + 2 * kWordSize));
   __ orl(EBX, EAX);
   __ testl(EBX, Immediate(kSmiTagMask));
   __ j(NOT_ZERO, not_smi, Assembler::kNearJump);
 }
@@ skipping 859 matching lines @@
   __ Bind(&is_true);
   __ LoadObject(EAX, bool_true);
   __ ret();
   return true;
 }
 
 #undef __
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32