Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5143)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10911149: Cleanup FaviconHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_tab_helper.h ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc
index cb851060da1d2eb0caf1420fa319615f5252efe6..ff5505ecab4550d0f1f65ae3f25f87842fe5c7fc 100644
--- a/chrome/browser/favicon/favicon_tab_helper.cc
+++ b/chrome/browser/favicon/favicon_tab_helper.cc
@@ -9,7 +9,6 @@
#include "chrome/browser/favicon/favicon_util.h"
#include "chrome/browser/history/history.h"
#include "chrome/browser/history/history_service_factory.h"
-#include "chrome/browser/history/select_favicon_frames.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_notification_types.h"
@@ -196,17 +195,10 @@ void FaviconTabHelper::OnDidDownloadFavicon(
bool errored,
int requested_size,
const std::vector<SkBitmap>& bitmaps) {
- float score = 0;
- // TODO: Possibly do bitmap selection in FaviconHandler, so that it can score
- // favicons better.
- std::vector<ui::ScaleFactor> scale_factors;
- scale_factors = ui::GetSupportedScaleFactors();
- gfx::Image favicon(SelectFaviconFrames(
- bitmaps, scale_factors, requested_size, &score));
favicon_handler_->OnDidDownloadFavicon(
- id, image_url, errored, favicon, score);
+ id, image_url, errored, requested_size, bitmaps);
if (touch_icon_handler_.get()) {
touch_icon_handler_->OnDidDownloadFavicon(
- id, image_url, errored, favicon, score);
+ id, image_url, errored, requested_size, bitmaps);
}
}
« no previous file with comments | « chrome/browser/favicon/favicon_tab_helper.h ('k') | chrome/browser/history/history_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698