Issue 10911140: Fix more ninja issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911140: Fix more ninja issues (Closed)

Created:
8 years, 3 months ago by Isaac (away)

Modified:
8 years, 3 months ago

Reviewers:
cmp, Yaron, nilesh

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, Siva Chandra

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix more ninja issues - single bracket tests fail when variable is empty - compiler_proxy zombies are causing memory leaks TBR=yfriedman@chromium.org,nileshagrawal1@chromium.org,cmp@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155303

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	build/android/buildbot/buildbot_functions.sh	View		4 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 3 months ago (2012-09-07 03:02:12 UTC) #2

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages