Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/WebCore/rendering/RenderQuote.cpp

Issue 10911116: Merge 126048 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/rendering/RenderQuote.h ('k') | Source/WebCore/rendering/RenderRegion.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 2011 Nokia Inc. All rights reserved. 2 * Copyright (C) 2011 Nokia Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 ASSERT(!m_attached); 43 ASSERT(!m_attached);
44 ASSERT(!m_next && !m_previous); 44 ASSERT(!m_next && !m_previous);
45 } 45 }
46 46
47 void RenderQuote::willBeDestroyed() 47 void RenderQuote::willBeDestroyed()
48 { 48 {
49 detachQuote(); 49 detachQuote();
50 RenderText::willBeDestroyed(); 50 RenderText::willBeDestroyed();
51 } 51 }
52 52
53 void RenderQuote::willBeRemovedFromTree()
54 {
55 RenderText::willBeRemovedFromTree();
56
57 detachQuote();
58 }
59
53 typedef HashMap<AtomicString, const QuotesData*, CaseFoldingHash> QuotesMap; 60 typedef HashMap<AtomicString, const QuotesData*, CaseFoldingHash> QuotesMap;
54 61
55 static const QuotesMap& quotesDataLanguageMap() 62 static const QuotesMap& quotesDataLanguageMap()
56 { 63 {
57 DEFINE_STATIC_LOCAL(QuotesMap, staticQuotesMap, ()); 64 DEFINE_STATIC_LOCAL(QuotesMap, staticQuotesMap, ());
58 if (staticQuotesMap.size()) 65 if (staticQuotesMap.size())
59 return staticQuotesMap; 66 return staticQuotesMap;
60 67
61 // Table of quotes from http://www.whatwg.org/specs/web-apps/current-work/mu ltipage/rendering.html#quotes 68 // Table of quotes from http://www.whatwg.org/specs/web-apps/current-work/mu ltipage/rendering.html#quotes
62 #define QUOTES_LANG(lang, o1, c1, o2, c2) staticQuotesMap.set(lang, QuotesDa ta::create(U(o1), U(c1), U(o2), U(c2)).leakRef()) 69 #define QUOTES_LANG(lang, o1, c1, o2, c2) staticQuotesMap.set(lang, QuotesDa ta::create(U(o1), U(c1), U(o2), U(c2)).leakRef())
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 } 356 }
350 // FIXME: Don't call setNeedsLayout or dirty our preferred widths during lay out. 357 // FIXME: Don't call setNeedsLayout or dirty our preferred widths during lay out.
351 // This is likely to fail anyway as one of our ancestor will call setNeedsLa yout(false), 358 // This is likely to fail anyway as one of our ancestor will call setNeedsLa yout(false),
352 // preventing the future layout to occur on |this|. The solution is to move that to a 359 // preventing the future layout to occur on |this|. The solution is to move that to a
353 // pre-layout phase. 360 // pre-layout phase.
354 if (oldDepth != m_depth) 361 if (oldDepth != m_depth)
355 setNeedsLayoutAndPrefWidthsRecalc(); 362 setNeedsLayoutAndPrefWidthsRecalc();
356 } 363 }
357 364
358 } // namespace WebCore 365 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/rendering/RenderQuote.h ('k') | Source/WebCore/rendering/RenderRegion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698