Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 10911099: Minor fixes in proxy configuration on iOS. (Closed)

Created:
8 years, 3 months ago by droger
Modified:
8 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Minor fixes in proxy configuration on iOS. Removes a unused argument to ProxyConfigServiceIOS, fixes a comment in ProxyConfigServiceMac, and make iOS use the same implementation of PrefProxyConfigTrackerImpl::ReadPrefConfig() as other platforms. This is a follow up to http://codereview.chromium.org/10882010/. BUG=145954 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155165

Patch Set 1 #

Patch Set 2 : indentation #

Total comments: 1

Patch Set 3 : Review comments" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -26 lines) Patch
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M net/proxy/proxy_config_service_ios.h View 1 2 1 chunk +1 line, -11 lines 0 comments Download
M net/proxy/proxy_config_service_ios.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M net/proxy/proxy_config_service_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
droger
8 years, 3 months ago (2012-09-05 15:00:59 UTC) #1
Ryan Sleevi
lgtm
8 years, 3 months ago (2012-09-05 15:27:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/10911099/2001
8 years, 3 months ago (2012-09-05 15:30:24 UTC) #3
commit-bot: I haz the power
Presubmit check for 10911099-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-05 15:30:33 UTC) #4
droger
+eroman as OWNER of chrome/browser/net.
8 years, 3 months ago (2012-09-05 15:51:39 UTC) #5
eroman
lgtm https://chromiumcodereview.appspot.com/10911099/diff/2001/net/proxy/proxy_config_service_ios.h File net/proxy/proxy_config_service_ios.h (right): https://chromiumcodereview.appspot.com/10911099/diff/2001/net/proxy/proxy_config_service_ios.h#newcode11 net/proxy/proxy_config_service_ios.h:11: class SingleThreadTaskRunner; can remove this now
8 years, 3 months ago (2012-09-05 18:44:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/10911099/7001
8 years, 3 months ago (2012-09-06 08:06:55 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-06 11:05:04 UTC) #8
Change committed as 155165

Powered by Google App Engine
This is Rietveld 408576698