Issue 10911098: ui: Keep the overrides in the same section of the superclass.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10911098: ui: Keep the overrides in the same section of the superclass. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, tfarina, ben+watch_chromium.org, piman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

ui: Keep the overrides in the same section of the superclass. When subclassing a non-pure virtual interface, prefer to keep them in the same section as in the superclass. This was discussed here: http://codereview.chromium.org/10914090/ R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155291

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -6 lines)			Patch
M	ui/app_list/test/app_list_test_suite.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/aura/test/test_suite.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/compositor/test/test_suite.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/views/run_all_unittests.cc	View	3 chunks	+7 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM