Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10911097: [Android] Upstream org.chromium.base.test.UrlUtils (partially) and device files (Closed)

Created:
8 years, 3 months ago by mnaganov (inactive)
Modified:
8 years, 3 months ago
Reviewers:
Torne, klundberg, joth, mkosiba (inactive), darin (slow to review), android-webview-reviews
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

[Android] Upstream org.chromium.base.test.UrlUtils (partially) and device files Required by android_webview AwSettingsTest BUG=146009 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156304

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments addressed #

Total comments: 2

Patch Set 3 : Fixed layering violation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -2 lines) Patch
A android_webview/test/data/device_files/chrome.png View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + android_webview/test/data/device_files/hello_world.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A android_webview/test/data/device_files/iframe_access.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A android_webview/test/data/device_files/image_access.html View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A android_webview/test/data/device_files/localStorage.html View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A android_webview/test/data/device_files/script.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A android_webview/test/data/device_files/xhr_access.html View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
A base/android/javatests/src/org/chromium/base/test/UrlUtils.java View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M base/base.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
mnaganov (inactive)
Karin, is it OK to upstream our test files into the same location as downstream? ...
8 years, 3 months ago (2012-09-05 12:43:24 UTC) #1
mkosiba (inactive)
LGTM https://chromiumcodereview.appspot.com/10911097/diff/1/base/base.gyp File base/base.gyp (right): https://chromiumcodereview.appspot.com/10911097/diff/1/base/base.gyp#newcode951 base/base.gyp:951: 'java_in_dir': 'android/javatests', do you need this change?
8 years, 3 months ago (2012-09-05 16:07:13 UTC) #2
klundberg
On 2012/09/05 12:43:24, Mikhail Naganov (Chromium) wrote: > Karin, is it OK to upstream our ...
8 years, 3 months ago (2012-09-05 16:46:52 UTC) #3
klundberg
lgtm Minor nit. https://chromiumcodereview.appspot.com/10911097/diff/1/chrome/test/data/android/device_files/webview/image_access.html File chrome/test/data/android/device_files/webview/image_access.html (right): https://chromiumcodereview.appspot.com/10911097/diff/1/chrome/test/data/android/device_files/webview/image_access.html#newcode9 chrome/test/data/android/device_files/webview/image_access.html:9: <!-- TODO(mnaganov): Remove setInterval once img.onload ...
8 years, 3 months ago (2012-09-05 16:47:03 UTC) #4
mnaganov (inactive)
https://chromiumcodereview.appspot.com/10911097/diff/1/base/base.gyp File base/base.gyp (right): https://chromiumcodereview.appspot.com/10911097/diff/1/base/base.gyp#newcode951 base/base.gyp:951: 'java_in_dir': 'android/javatests', On 2012/09/05 16:07:13, Martin Kosiba wrote: > ...
8 years, 3 months ago (2012-09-05 16:58:10 UTC) #5
mnaganov (inactive)
Darin, kindly asking for an owner's rubber stamp. These changes are related only to Android.
8 years, 3 months ago (2012-09-05 17:05:01 UTC) #6
darin (slow to review)
https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java File base/android/javatests/src/org/chromium/base/test/UrlUtils.java (right): https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java#newcode12 base/android/javatests/src/org/chromium/base/test/UrlUtils.java:12: private final static String DATA_DIR = "file:///sdcard/chrome/test/data/"; It seems ...
8 years, 3 months ago (2012-09-05 17:49:11 UTC) #7
boliu
On 2012/09/05 17:49:11, darin wrote: > https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java > File base/android/javatests/src/org/chromium/base/test/UrlUtils.java (right): > > https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java#newcode12 > ...
8 years, 3 months ago (2012-09-05 21:01:09 UTC) #8
mnaganov (inactive)
https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java File base/android/javatests/src/org/chromium/base/test/UrlUtils.java (right): https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java#newcode12 base/android/javatests/src/org/chromium/base/test/UrlUtils.java:12: private final static String DATA_DIR = "file:///sdcard/chrome/test/data/"; On 2012/09/05 ...
8 years, 3 months ago (2012-09-11 16:59:40 UTC) #9
mnaganov (inactive)
On 2012/09/11 16:59:40, Mikhail Naganov (Chromium) wrote: > https://chromiumcodereview.appspot.com/10911097/diff/8001/base/android/javatests/src/org/chromium/base/test/UrlUtils.java > File base/android/javatests/src/org/chromium/base/test/UrlUtils.java (right): > > ...
8 years, 3 months ago (2012-09-11 17:09:23 UTC) #10
darin (slow to review)
LGTM for base/
8 years, 3 months ago (2012-09-11 19:25:37 UTC) #11
Torne
lgtm
8 years, 3 months ago (2012-09-12 15:37:04 UTC) #12
joth
8 years, 3 months ago (2012-09-12 21:30:14 UTC) #13
lgtm

Powered by Google App Engine
This is Rietveld 408576698