Issue 4903. Better error message when static method attempts to use type variable

compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.resolver;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.DartCompilerContext;
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ErrorSeverity;
+import com.google.dart.compiler.PackageLibraryManager;
 import com.google.dart.compiler.Source;
 import com.google.dart.compiler.SubSystem;
-import com.google.dart.compiler.PackageLibraryManager;
 import com.google.dart.compiler.ast.ASTVisitor;
 import com.google.dart.compiler.ast.DartFunctionExpression;
 import com.google.dart.compiler.ast.DartFunctionTypeAlias;
 import com.google.dart.compiler.ast.DartIdentifier;
 import com.google.dart.compiler.ast.DartNode;
 import com.google.dart.compiler.ast.DartPropertyAccess;
 import com.google.dart.compiler.ast.DartSyntheticErrorIdentifier;
 import com.google.dart.compiler.ast.DartTypeNode;
 import com.google.dart.compiler.ast.LibraryUnit;
 import com.google.dart.compiler.ast.Modifiers;
@@ skipping 212 matching lines @@
             case CLASS:
             case FUNCTION_TYPE_ALIAS:
             return instantiateParameterizedType((ClassElement)existingElement,
                                                 diagnosticNode,
                                                 typeArguments,
                                                 isStatic,
                                                 isFactory,
                                                 errorCode,
                                                 wrongNumberErrorCode);
             case NONE:
+            default:
               if (errorCode.getSubSystem().equals(SubSystem.RESOLVER)) {
                 onError(identifier, ResolverErrorCode.TYPE_VARIABLE_IN_STATIC_CONTEXT,
                     identifier);
               } else {
                 onError(identifier, TypeErrorCode.TYPE_VARIABLE_IN_STATIC_CONTEXT,
                     identifier);
               }
               return typeProvider.getDynamicType();
-
-            default:
-              if (errorCode.getSubSystem().equals(SubSystem.RESOLVER)) {
-                onError(identifier, ResolverErrorCode.NOT_A_TYPE, identifier, elementKind);
-              } else {
-                onError(identifier, TypeErrorCode.NOT_A_TYPE, identifier, elementKind);
-              }
-              return typeProvider.getDynamicType();
           }
         }
         return makeTypeVariable(typeVariableElement, typeArguments);
       }
       case CLASS:
       case FUNCTION_TYPE_ALIAS:
         return instantiateParameterizedType(
             (ClassElement) element,
             diagnosticNode,
             typeArguments,
@@ skipping 141 matching lines @@
       String name = node.getName();
       return scope.findElement(scope.getLibrary(), name);
     }
 
     @Override
     public Element visitSyntheticErrorIdentifier(DartSyntheticErrorIdentifier node) {
       return Elements.dynamicElement();
     }
   }
 }