Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/extensions/web_intent_callbacks.cc

Issue 10911072: [Coverity] Pass-by-val -> pass-by-ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/web_intent_callbacks.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/web_intent_callbacks.cc
diff --git a/chrome/browser/extensions/web_intent_callbacks.cc b/chrome/browser/extensions/web_intent_callbacks.cc
index c83000488a79acb58f8aeba4faec5a4ccfea5cad..38708b4523adb7ecbb1a9de01ac6b54e0980816c 100644
--- a/chrome/browser/extensions/web_intent_callbacks.cc
+++ b/chrome/browser/extensions/web_intent_callbacks.cc
@@ -28,7 +28,7 @@ class WebIntentCallbacks::SourceObserver : content::WebContentsObserver {
public:
SourceObserver(content::WebContents* web_contents,
WebIntentCallbacks* callbacks,
- const std::string key)
+ const std::string& key)
: content::WebContentsObserver(web_contents),
callbacks_(callbacks),
key_(key) {}
@@ -89,7 +89,7 @@ content::WebIntentsDispatcher* WebIntentCallbacks::RetrieveCallback(
}
content::WebIntentsDispatcher* WebIntentCallbacks::GetAndClear(
- std::string key) {
+ const std::string& key) {
if (!pending_.count(key))
return NULL;
« no previous file with comments | « chrome/browser/extensions/web_intent_callbacks.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698