runtime/vm/flow_graph_optimizer.cc - Issue 10911057: Add check for non-smi to the IL and use it for class checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10911057: Add check for non-smi to the IL and use it for class checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 11768)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -313,8 +313,11 @@

// Type propagation has not run yet, we cannot eliminate the check.

const ICData& unary_checks =

ICData::ZoneHandle(comp->ic_data()->AsUnaryClassChecks());

- CheckClassComp* check = new CheckClassComp(value, comp, unary_checks);

- InsertBefore(instr, check, instr->env(), Definition::kEffect);

+ CheckNonSmiComp* check_non_smi = new CheckNonSmiComp(value->Copy(),

+ comp->deopt_id());

+ InsertBefore(instr, check_non_smi, instr->env(), Definition::kEffect);

+ CheckClassComp* check_class = new CheckClassComp(value, comp, unary_checks);

+ InsertBefore(instr, check_class, instr->env(), Definition::kEffect);

}

« no previous file with comments | « runtime/vm/code_generator.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »