Extension Commands: Make sure we can open the Configure Commands overlay from the install bubble.

chrome/browser/resources/extensions/extensions.js

Index: chrome/browser/resources/extensions/extensions.js
===================================================================
--- chrome/browser/resources/extensions/extensions.js	(revision 154111)
+++ chrome/browser/resources/extensions/extensions.js	(working copy)
@@ -116,6 +116,14 @@
 
       extensions.ExtensionFocusManager.getInstance().initialize();
 
+      var path = document.location.pathname;
+      if (path.length > 1) {
+        // Skip starting slash and remove trailing slash (if any).
+        var overlayName = path.slice(1).replace(/\/$/, '');
+        if (overlayName == 'configureCommands')
+          this.showExtensionCommandsConfigUi_();
+      }

[Finnur, 2012/08/31 16:29:31]

I opted for a similar but simpler scheme of opening overlays (than the one we
have on the options page). I looked into incorporating the same scheme we have
for the options page, but the framework for doing this on the options page isn't
there on the extensions page and it looks like a lot of work to figure out all
the things that need to be incorporated and factor them out so they can be
shared.

Some things to bear in mind:

The only purpose of this it to support clicking a [Configure Shortcut] link
inside a bubble within the Chrome UI (extension install bubble).

We don't have another overlay that we want to be addressable through a URL at
present time.

This doesn't need to be user discoverable or even usable manually, although
adding configureCommands by hand to the URL does the right thing.

+
       preventDefaultOnPoundLinkClicks();  // From shared/js/util.js.
     },
 
@@ -144,17 +152,26 @@
     },
 
     /**
-     * Handles the Configure (Extension) Commands link.
+     * Shows the Extension Commands configuration UI.
      * @param {Event} e Change event.
      * @private
      */
-    handleExtensionCommandsConfig_: function(e) {
+    showExtensionCommandsConfigUi_: function(e) {
       ExtensionSettings.showOverlay($('extensionCommandsOverlay'));
       chrome.send('coreOptionsUserMetricsAction',
                   ['Options_ExtensionCommands']);
     },
 
     /**
+     * Handles the Configure (Extension) Commands link.
+     * @param {Event} e Change event.
+     * @private
+     */
+    handleExtensionCommandsConfig_: function(e) {
+      this.showExtensionCommandsConfigUi_();
+    },
+
+    /**
      * Handles the Update Extension Now button.
      * @param {Event} e Change event.
      * @private