Extension Commands: Make sure we can open the Configure Commands overlay from the install bubble.

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js"></include>
 <include src="extension_commands_overlay.js"></include>
 <include src="extension_focus_manager.js"></include>
 <include src="extension_list.js"></include>
 <include src="pack_extension_overlay.js"></include>
 
@@ skipping 98 matching lines @@
 
       // Initialize the Commands overlay.
       var extensionCommandsOverlay =
           extensions.ExtensionCommandsOverlay.getInstance();
       extensionCommandsOverlay.initializePage();
 
       cr.ui.overlay.setupOverlay($('dropTargetOverlay'));
 
       extensions.ExtensionFocusManager.getInstance().initialize();
 
+      var path = document.location.pathname;
+      if (path.length > 1) {
+        // Skip starting slash and remove trailing slash (if any).
+        var overlayName = path.slice(1).replace(/\/$/, '');
+        if (overlayName == 'configureCommands')
+          this.showExtensionCommandsConfigUi_();
+      }

[Finnur, 2012/08/31 16:29:31]

I opted for a similar but simpler scheme of opening overlays (than the one we
have on the options page). I looked into incorporating the same scheme we have
for the options page, but the framework for doing this on the options page isn't
there on the extensions page and it looks like a lot of work to figure out all
the things that need to be incorporated and factor them out so they can be
shared.

Some things to bear in mind:

The only purpose of this it to support clicking a [Configure Shortcut] link
inside a bubble within the Chrome UI (extension install bubble).

We don't have another overlay that we want to be addressable through a URL at
present time.

This doesn't need to be user discoverable or even usable manually, although
adding configureCommands by hand to the URL does the right thing.

+
       preventDefaultOnPoundLinkClicks();  // From shared/js/util.js.
     },
 
     /**
      * Handles the Load Unpacked Extension button.
      * @param {Event} e Change event.
      * @private
      */
     handleLoadUnpackedExtension_: function(e) {
       chrome.send('extensionSettingsLoadUnpackedExtension');
 
       // TODO(jhawkins): Refactor metrics support out of options and use it
       // in extensions.html.
       chrome.send('coreOptionsUserMetricsAction',
                   ['Options_LoadUnpackedExtension']);
     },
 
     /**
      * Handles the Pack Extension button.
      * @param {Event} e Change event.
      * @private
      */
     handlePackExtension_: function(e) {
       ExtensionSettings.showOverlay($('packExtensionOverlay'));
       chrome.send('coreOptionsUserMetricsAction', ['Options_PackExtension']);
     },
 
     /**
+     * Shows the Extension Commands configuration UI.
+     * @param {Event} e Change event.
+     * @private
+     */
+    showExtensionCommandsConfigUi_: function(e) {
+      ExtensionSettings.showOverlay($('extensionCommandsOverlay'));
+      chrome.send('coreOptionsUserMetricsAction',
+                  ['Options_ExtensionCommands']);
+    },
+
+    /**
      * Handles the Configure (Extension) Commands link.
      * @param {Event} e Change event.
      * @private
      */
     handleExtensionCommandsConfig_: function(e) {
-      ExtensionSettings.showOverlay($('extensionCommandsOverlay'));
-      chrome.send('coreOptionsUserMetricsAction',
-                  ['Options_ExtensionCommands']);
+      this.showExtensionCommandsConfigUi_();
     },
 
     /**
      * Handles the Update Extension Now button.
      * @param {Event} e Change event.
      * @private
      */
     handleUpdateExtensionNow_: function(e) {
       chrome.send('extensionSettingsAutoupdate');
     },
@@ skipping 168 matching lines @@
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 var ExtensionSettings = extensions.ExtensionSettings;
 
 window.addEventListener('load', function(e) {
   ExtensionSettings.getInstance().initialize();
 });