Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 10911032: Extension Commands: Make sure we can open the Configure Commands overlay from the install bubble. (Closed)

Created:
8 years, 3 months ago by Finnur
Modified:
8 years, 3 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Extension Commands: Make sure we can open the Configure Commands overlay from the install bubble. When an extension with an Extension Command is installed, we show an installation bubble. We want to add to that bubble a "Configure shortcut" link that takes you directly to the Extensions page with the Configure Command overlay open. We have infrastructure for doing this in the Settings page, but that infrastructure isn't there for the Extensions page. This buys us time, allowing us to complete the installation bubble link. BUG=145951 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154752

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/resources/extensions/extensions.js View 1 2 chunks +19 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Finnur
http://codereview.chromium.org/10911032/diff/3002/chrome/browser/resources/extensions/extensions.js File chrome/browser/resources/extensions/extensions.js (right): http://codereview.chromium.org/10911032/diff/3002/chrome/browser/resources/extensions/extensions.js#newcode125 chrome/browser/resources/extensions/extensions.js:125: } I opted for a similar but simpler scheme ...
8 years, 3 months ago (2012-08-31 16:29:31 UTC) #1
Finnur
jhawkins: ping. BTW, here is what I intend to use this change for: http://codereview.chromium.org/10910064/ (just ...
8 years, 3 months ago (2012-09-03 14:18:15 UTC) #2
Finnur
Ah, I had forgotten about labor day. Anyway, please take a look when you get ...
8 years, 3 months ago (2012-09-04 10:49:47 UTC) #3
James Hawkins
8 years, 3 months ago (2012-09-04 14:27:59 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698