testing/xvfb.py - Issue 10911014: Enable Chrome Sandbox with run_test_cases.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/xvfb.py

Issue 10911014: Enable Chrome Sandbox with run_test_cases.py (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Changing test_env Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/xvfb.py

diff --git a/testing/xvfb.py b/testing/xvfb.py

index e8feaacd0cbcc99119e05ef8b42ea98b2b27ab35..6ac00567101857bf5d054e52247c5b22c4238864 100755

--- a/testing/xvfb.py

+++ b/testing/xvfb.py

@@ -113,7 +113,7 @@ def run_executable(cmd, build_dir, env):

subprocess.Popen(

ice_cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, env=env)

except OSError:

- print >> sys.stderr, 'Failed to run %s' % ' '.join(cmd)

+ print >> sys.stderr, 'Failed to run %s' % ' '.join(ice_cmd)

M-A Ruel 2012/08/30 19:43:17 Argh. Thanks!

csharp 2012/08/30 20:17:48 No problem, I think I was the one who introduced t

return 1

return test_env.run_executable(cmd, env)

finally:

« testing/test_env.py ('K') | « testing/test_env.py ('k') | no next file » | no next file with comments »