Upstream Android IME support (ImeAdapter).

Upstream Android IME support (ImeAdapter).

This CL contains most of the ImeAdapter code that allows Android IMEs to work with Chrome. The
key class is ImeAdapter on the Android/Java side, which has an inner class AdapterInputConnection
which implements Android's inputConnection interface. Also important is the method
ContentViewCore#imeUpdateAdapter, which is called in response to ViewHostMsg_TextInputStateChanged
messsages from the renderer.

This CL also adds SelectionHandleController and InsertionHandleController, but only as stubs.

BUG=136691
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154687

[James Su, 2012-08-31 02:05:25]

The C++ part LGTM.

https://chromiumcodereview.appspot.com/10911012/diff/1/content/common/view_me...
File content/common/view_messages.h (right):

https://chromiumcodereview.appspot.com/10911012/diff/1/content/common/view_me...
content/common/view_messages.h:1026:
IPC_MESSAGE_ROUTED3(ViewMsg_SetCompositionFromExistingText,
nit: How about group this message and ViewMsg_ImeSetComposition together?

[bulach, 2012-08-31 11:36:23]

lgtm for the java side, just a couple of nits:

https://chromiumcodereview.appspot.com/10911012/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://chromiumcodereview.appspot.com/10911012/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_android.cc:186:
reinterpret_cast<int>(&ime_adapter_android_),
nit: could use GetNativeImeAdapter() here.

https://chromiumcodereview.appspot.com/10911012/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/InsertionHandleController.java
(right):

https://chromiumcodereview.appspot.com/10911012/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InsertionHandleController.java:10:
public class InsertionHandleController {
nit: does it need to be public? SelectionHandleController doesn't seem to be..

[olilan, 2012-08-31 16:47:09]

Thanks guys. Nits resolved. Also patch 2 adds some recent downstream fixes, and
adds RegisterImeAdapter to browser_jni_registrar.

https://chromiumcodereview.appspot.com/10911012/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://chromiumcodereview.appspot.com/10911012/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_android.cc:186:
reinterpret_cast<int>(&ime_adapter_android_),
On 2012/08/31 11:36:24, bulach wrote:
> nit: could use GetNativeImeAdapter() here.

Done.

https://chromiumcodereview.appspot.com/10911012/diff/1/content/common/view_me...
File content/common/view_messages.h (right):

https://chromiumcodereview.appspot.com/10911012/diff/1/content/common/view_me...
content/common/view_messages.h:1026:
IPC_MESSAGE_ROUTED3(ViewMsg_SetCompositionFromExistingText,
On 2012/08/31 02:05:25, James Su wrote:
> nit: How about group this message and ViewMsg_ImeSetComposition together?

Moved these three to be next to the other text input / composition related
messages.

https://chromiumcodereview.appspot.com/10911012/diff/1/content/public/android...
File
content/public/android/java/src/org/chromium/content/browser/InsertionHandleController.java
(right):

https://chromiumcodereview.appspot.com/10911012/diff/1/content/public/android...
content/public/android/java/src/org/chromium/content/browser/InsertionHandleController.java:10:
public class InsertionHandleController {
On 2012/08/31 11:36:24, bulach wrote:
> nit: does it need to be public? SelectionHandleController doesn't seem to be..

changed to package-private

[olilan, 2012-08-31 16:55:42]

jam, could you ptal as an owner of content/ ?

[jam, 2012-08-31 16:59:12]

lgtm

[commit-bot: I haz the power, 2012-09-03 10:47:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/olilan@chromium.org/10911012/10001

[commit-bot: I haz the power, 2012-09-03 13:10:11]

Change committed as 154687