Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: lib/compiler/implementation/js_backend/native_emitter.dart

Issue 10911006: Collect the types used in is-checks in the resolver phase. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/js_backend/native_emitter.dart
diff --git a/lib/compiler/implementation/js_backend/native_emitter.dart b/lib/compiler/implementation/js_backend/native_emitter.dart
index 673c98822ac3d95ef585605ddb752b5020a8c739..d47816b639831e4d7fca6586de69595221e3ebe8 100644
--- a/lib/compiler/implementation/js_backend/native_emitter.dart
+++ b/lib/compiler/implementation/js_backend/native_emitter.dart
@@ -383,9 +383,10 @@ function(cls, fields, methods) {
}
void emitIsChecks(Map<String, String> objectProperties) {
- for (Element type in compiler.codegenWorld.isChecks) {
- if (!requiresNativeIsCheck(type)) continue;
- String name = compiler.namer.operatorIs(type);
+ for (Type type in compiler.codegenWorld.isChecks) {
ngeoffray 2012/08/30 13:17:46 Shouldn't you use checkedClasses here also? otherw
karlklose 2012/09/05 09:36:01 Done.
+ Element element = type.element;
+ if (!requiresNativeIsCheck(element)) continue;
+ String name = compiler.namer.operatorIs(element);
objectProperties[name] = 'function() { return false; }';
}
}

Powered by Google App Engine
This is Rietveld 408576698