Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10911006: Collect the types used in is-checks in the resolver phase. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix last upload. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index b5d0b128082b5e8944a8cda3db67fb12e656ea36..fd07c22f30218b42745e9a3dee414fe15955a9c1 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -2668,7 +2668,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
if (element != null && element.isErroneous()) {
ErroneousElement error = element;
Message message = error.errorMessage;
- if (message.kind === MessageKind.CANNOT_FIND_CONSTRUCTOR) {
+ if (message.kind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
Element helper =
compiler.findHelper(const SourceString('throwNoSuchMethod'));
DartString receiverLiteral = new DartString.literal('');
@@ -2685,7 +2685,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
HInstruction arguments = new HLiteralList(inputs);
add(arguments);
pushInvokeHelper3(helper, receiver, name, arguments);
- } else if (message.kind === MessageKind.CANNOT_RESOLVE) {
+ } else if (message.kind == MessageKind.CANNOT_RESOLVE) {
generateRuntimeError(node.send, message.message);
} else {
compiler.internalError('unexpected unresolved constructor call',

Powered by Google App Engine
This is Rietveld 408576698