chrome/browser/extensions/api/app_window/app_window_api.cc - Issue 10910304: Cache the object given to the chrome.app.window.create callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_api.cc

Issue 10910304: Cache the object given to the chrome.app.window.create callback (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: rebase to r157512 (conflicts) Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/app_window/app_window_api.cc

diff --git a/chrome/browser/extensions/api/app_window/app_window_api.cc b/chrome/browser/extensions/api/app_window/app_window_api.cc

index bf85d462a5a71cee268c9819862499a1e5157089..97dcd1c195d11743b658a43e703b42493dce3964 100644

--- a/chrome/browser/extensions/api/app_window/app_window_api.cc

+++ b/chrome/browser/extensions/api/app_window/app_window_api.cc

@@ -134,6 +134,7 @@ bool AppWindowCreateFunction::RunImpl() {

result->Set("viewId", base::Value::CreateIntegerValue(view_id));

result->Set("injectTitlebar",

base::Value::CreateBooleanValue(inject_html_titlebar));

+ result->Set("id", base::Value::CreateStringValue(shell_window->window_key()));

SetResult(result);

return true;

}

« no previous file with comments | « no previous file | chrome/browser/ui/extensions/shell_window.h » ('j') | chrome/common/extensions/api/app_window.idl » ('J')