Issue 10910291: Changing return value of request animation frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910291: Changing return value of request animation frame. (Closed)

Created:
8 years, 3 months ago by blois

Modified:
8 years, 3 months ago

Reviewers:
vsm, Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Changing return value of request animation frame. This should now be working after http://code.google.com/p/dart/source/detail?r=12440 BUG=3469 Committed: https://code.google.com/p/dart/source/detail?r=12508

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -4 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/html/idl/dart/dart.idl	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	lib/html/templates/html/dart2js/impl_Window.darttemplate	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 3 months ago (2012-09-19 09:31:45 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/10910291/diff/1/lib/html/idl/dart/dart...
File lib/html/idl/dart/dart.idl (right):

https://chromiumcodereview.appspot.com/10910291/diff/1/lib/html/idl/dart/dart...
lib/html/idl/dart/dart.idl:351: [supplemental, Callback]
nit: <S>upplemental

Expand Messages | Collapse Messages