alternate ntp: show search provider logo

alternate ntp: show search provider logo

- add option to show search provider logo at chrome://instant, enhance js to include and handle checkbox input beside number input
- NTP shows google logo if default search provider is google and option is checked, else a red box is shown.
- enhance animation scale factor: increase max to 20, set max for spin

BUG=148765
TEST=verfiy per bug rpt


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157457

[kuan, 2012-09-14 19:48:12]

this cl implements the google logo option and image for ntp page, details in
description.  i'll land the google logo image in a separate cl when this cl is
lgtm'ed.  after this cl has landed, i'll create a 3rd cl to remove the currently
branded google logo image.

ptal.  thx.

[sky, 2012-09-14 21:35:25]

LGTM - but you should really get some one to review the webui changes.

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/instant_ui.cc (right):

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.cc:46: static int show_search_provider_logo()
{
bool

[dhollowa, 2012-09-14 22:01:56]

+1 on WebUI review.  Otherwise LGTM w/ nits.

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/instant_ui.cc (right):

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.cc:144: int
InstantUI::ShouldShowSearchProviderLogo() {
bool

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/instant_ui.h (right):

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.h:20: // Returns if search provider logo
should be shown.
"Returns true if..."

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.h:21: static int
ShouldShowSearchProviderLogo();
bool

[dhollowa, 2012-09-14 22:05:02]

Also, please wait for Gideon's LGTM on this.  Thanks.

On 2012/09/14 22:01:56, dhollowa wrote:
> +1 on WebUI review.  Otherwise LGTM w/ nits.
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> File chrome/browser/ui/webui/instant_ui.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.cc:144: int
> InstantUI::ShouldShowSearchProviderLogo() {
> bool
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> File chrome/browser/ui/webui/instant_ui.h (right):
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.h:20: // Returns if search provider logo
> should be shown.
> "Returns true if..."
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.h:21: static int
> ShouldShowSearchProviderLogo();
> bool

[kuan, 2012-09-14 22:34:09]

james, ptal for webui files.

david, scott,
i've addressed all comments in patch set 3.  yeah, i planned to add a webui
owner after u both had lgtm'ed, +jhawkins.

david, i don't expect this to go in until next wk, and i'll wait for gideon.

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/instant_ui.cc (right):

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.cc:46: static int show_search_provider_logo()
{
On 2012/09/14 21:35:30, sky wrote:
> bool

Done.

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.cc:144: int
InstantUI::ShouldShowSearchProviderLogo() {
On 2012/09/14 22:01:56, dhollowa wrote:
> bool

Done.

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
File chrome/browser/ui/webui/instant_ui.h (right):

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.h:20: // Returns if search provider logo
should be shown.
On 2012/09/14 22:01:56, dhollowa wrote:
> "Returns true if..."

Done.

https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
chrome/browser/ui/webui/instant_ui.h:21: static int
ShouldShowSearchProviderLogo();
On 2012/09/14 22:01:56, dhollowa wrote:
> bool

Done.

[gideonwald, 2012-09-16 07:26:47]

On 2012/09/14 22:34:09, kuan wrote:
> james, ptal for webui files.
> 
> david, scott,
> i've addressed all comments in patch set 3.  yeah, i planned to add a webui
> owner after u both had lgtm'ed, +jhawkins.
> 
> david, i don't expect this to go in until next wk, and i'll wait for gideon.

LGTM! Thanks a lot, Kuan.

> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> File chrome/browser/ui/webui/instant_ui.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.cc:46: static int
show_search_provider_logo()
> {
> On 2012/09/14 21:35:30, sky wrote:
> > bool
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.cc:144: int
> InstantUI::ShouldShowSearchProviderLogo() {
> On 2012/09/14 22:01:56, dhollowa wrote:
> > bool
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> File chrome/browser/ui/webui/instant_ui.h (right):
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.h:20: // Returns if search provider logo
> should be shown.
> On 2012/09/14 22:01:56, dhollowa wrote:
> > "Returns true if..."
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/10910286/diff/2001/chrome/browser/ui/w...
> chrome/browser/ui/webui/instant_ui.h:21: static int
> ShouldShowSearchProviderLogo();
> On 2012/09/14 22:01:56, dhollowa wrote:
> > bool
> 
> Done.

[kuan, 2012-09-18 17:50:11]

james, ping.. cld u ptal at *.js and webui files?  u reviewed the previous
changes to the same files, so i figure u're the best person to review the latest
changes.  thx!

[James Hawkins, 2012-09-18 17:52:30]

LGTM with nit.

http://codereview.chromium.org/10910286/diff/9001/chrome/browser/ui/webui/ins...
File chrome/browser/ui/webui/instant_ui.cc (right):

http://codereview.chromium.org/10910286/diff/9001/chrome/browser/ui/webui/ins...
chrome/browser/ui/webui/instant_ui.cc:57: // if search provider logo should be
shown.
// True if search...

[kuan, 2012-09-18 20:48:45]

i've addressed all comments, sending to CQ now...

http://codereview.chromium.org/10910286/diff/9001/chrome/browser/ui/webui/ins...
File chrome/browser/ui/webui/instant_ui.cc (right):

http://codereview.chromium.org/10910286/diff/9001/chrome/browser/ui/webui/ins...
chrome/browser/ui/webui/instant_ui.cc:57: // if search provider logo should be
shown.
On 2012/09/18 17:52:30, James Hawkins wrote:
> // True if search...

Done.

[commit-bot: I haz the power, 2012-09-18 20:48:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kuan@chromium.org/10910286/17002

[commit-bot: I haz the power, 2012-09-18 22:41:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-18 22:48:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kuan@chromium.org/10910286/17002

[commit-bot: I haz the power, 2012-09-19 00:09:12]

Change committed as 157457